pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Grigorev Jurij <ju.grigorev@ftdata.ru>
To: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: DSA_ALLOC_NO_OOM vs dsm_create ERROR leaving a half-initialized pgstats hash entry
Date: Thu, 24 Sep 2026 03:39:10 +0000
Message-ID: <ee29f27c0c9f4520b3cf2135f7dc7a2b@localhost.localdomain> (raw)
In-Reply-To: <arRmqBEj9n0w3qCc@paquier.xyz>
References: <ddc3ecfb01ce4e9698b23cc59767f016@localhost.localdomain>
	<aqCfwe5-EIiJXlIu@paquier.xyz>
	<a72c99d5b1e448b191a89e30ecaf3e8a@localhost.localdomain>
	<aqtU-qs5H3LbUum1@paquier.xyz>
	<aqtiKTvl519bu8-V@paquier.xyz>
	<d6ed296c81c14d03b1b5e283e913c40b@localhost.localdomain>
	<aquSa2gbfVMxDYmT@paquier.xyz>
	<0eb7233253374bce9f8ec0111a40b732@localhost.localdomain>
	<arRmqBEj9n0w3qCc@paquier.xyz>

Hi Michael,

Thanks very much for taking the time to clean this up and commit it.  I
reviewed d9de60c -- restoring the existing refcount and generation
comments was the right call, and the shorter wording still captures the
allocation-before-insert invariant.  The final ordering and cleanup
paths look good to me.

Thanks,
  Yuriy





view thread (10+ messages)

Message-ID: <ee29f27c0c9f4520b3cf2135f7dc7a2b@localhost.localdomain>
Permalink:  ../ee29f27c0c9f4520b3cf2135f7dc7a2b@localhost.localdomain/
Also on:    postgresql.org/message-id/ee29f27c0c9f4520b3cf2135f7dc7a2b@localhost.localdomain

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: ju.grigorev@ftdata.ru, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
  Subject: Re: DSA_ALLOC_NO_OOM vs dsm_create ERROR leaving a half-initialized pgstats hash entry
  In-Reply-To: <ee29f27c0c9f4520b3cf2135f7dc7a2b@localhost.localdomain>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox