pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Pavel Luzanov <p.luzanov@postgrespro.ru>
To: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Subject: postgresql.conf.sample missing units
Date: Mon, 19 Jul 2021 12:44:50 +0300
Message-ID: <f10d16fc-8fa0-1b3c-7371-cb3a35a13b7a@postgrespro.ru> (raw)

Hello,

I found that the start section of the postgresql.conf file is missing a 
description of two units: bytes (appeared in version 11) and 
microseconds (in version 12).

The attached patch makes these changes to the postgresql.conf.sample file.

-- 
Pavel Luzanov
Postgres Professional: https://postgrespro.com
The Russian Postgres Company

Attachments:

add-units-in-sample.patch (text/x-patch, 794B) download
diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample
index ccaaf63850..b242a7fc8b 100644
--- a/src/backend/utils/misc/postgresql.conf.sample
+++ b/src/backend/utils/misc/postgresql.conf.sample
@@ -24,7 +24,8 @@
 # "postgres -c log_connections=on".  Some parameters can be changed at run time
 # with the "SET" SQL command.
 #
-# Memory units:  kB = kilobytes        Time units:  ms  = milliseconds
+# Memory units:  B  = bytes            Time units:  us  = microseconds
+#                kB = kilobytes                     ms  = milliseconds
 #                MB = megabytes                     s   = seconds
 #                GB = gigabytes                     min = minutes
 #                TB = terabytes                     h   = hours

view thread (4+ messages)  latest in thread

Message-ID: <f10d16fc-8fa0-1b3c-7371-cb3a35a13b7a@postgrespro.ru>
Permalink:  ../f10d16fc-8fa0-1b3c-7371-cb3a35a13b7a@postgrespro.ru/
Also on:    postgresql.org/message-id/f10d16fc-8fa0-1b3c-7371-cb3a35a13b7a@postgrespro.ru

copy link · copy postgr.es · copy git am

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: p.luzanov@postgrespro.ru, pgsql-hackers@lists.postgresql.org
  Subject: Re: postgresql.conf.sample missing units
  In-Reply-To: <f10d16fc-8fa0-1b3c-7371-cb3a35a13b7a@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox