pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedpostgresql.conf.sample missing units
4+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2021-07-21 7155e0522f Document "B" as an accepted unit in postgres.conf.sample
2021-07-21 bb95feabb8 65cc77c984 0b5dc1f171 4b39d5c69a Document "B" and "us" as accepted units in postgres.conf.sample
* postgresql.conf.sample missing units
@ 2021-07-19 09:44 Pavel Luzanov <p.luzanov@postgrespro.ru>
2021-07-19 14:31 ` Re: postgresql.conf.sample missing units John Naylor <john.naylor@enterprisedb.com>
0 siblings, 1 reply; 4+ messages in thread
From: Pavel Luzanov @ 2021-07-19 09:44 UTC (permalink / raw)
To: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Hello,
I found that the start section of the postgresql.conf file is missing a
description of two units: bytes (appeared in version 11) and
microseconds (in version 12).
The attached patch makes these changes to the postgresql.conf.sample file.
--
Pavel Luzanov
Postgres Professional: https://postgrespro.com
The Russian Postgres Company
Attachments:
add-units-in-sample.patch (text/x-patch, 794B) download
diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample
index ccaaf63850..b242a7fc8b 100644
--- a/src/backend/utils/misc/postgresql.conf.sample
+++ b/src/backend/utils/misc/postgresql.conf.sample
@@ -24,7 +24,8 @@
# "postgres -c log_connections=on". Some parameters can be changed at run time
# with the "SET" SQL command.
#
-# Memory units: kB = kilobytes Time units: ms = milliseconds
+# Memory units: B = bytes Time units: us = microseconds
+# kB = kilobytes ms = milliseconds
# MB = megabytes s = seconds
# GB = gigabytes min = minutes
# TB = terabytes h = hours
* Re: postgresql.conf.sample missing units
2021-07-19 09:44 postgresql.conf.sample missing units Pavel Luzanov <p.luzanov@postgrespro.ru>
@ 2021-07-19 14:31 ` John Naylor <john.naylor@enterprisedb.com>
2021-07-21 14:33 ` Re: postgresql.conf.sample missing units John Naylor <john.naylor@enterprisedb.com>
0 siblings, 1 reply; 4+ messages in thread
From: John Naylor @ 2021-07-19 14:31 UTC (permalink / raw)
To: Pavel Luzanov <p.luzanov@postgrespro.ru>; +Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
On Mon, Jul 19, 2021 at 5:44 AM Pavel Luzanov <p.luzanov@postgrespro.ru>
wrote:
>
> Hello,
>
> I found that the start section of the postgresql.conf file is missing a
> description of two units: bytes (appeared in version 11) and
> microseconds (in version 12).
>
> The attached patch makes these changes to the postgresql.conf.sample file.
Seems like an oversight. I'll commit this soon barring objections.
--
John Naylor
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: postgresql.conf.sample missing units
2021-07-19 09:44 postgresql.conf.sample missing units Pavel Luzanov <p.luzanov@postgrespro.ru>
2021-07-19 14:31 ` Re: postgresql.conf.sample missing units John Naylor <john.naylor@enterprisedb.com>
@ 2021-07-21 14:33 ` John Naylor <john.naylor@enterprisedb.com>
2021-07-22 10:14 ` Re: postgresql.conf.sample missing units Pavel Luzanov <p.luzanov@postgrespro.ru>
0 siblings, 1 reply; 4+ messages in thread
From: John Naylor @ 2021-07-21 14:33 UTC (permalink / raw)
To: Pavel Luzanov <p.luzanov@postgrespro.ru>; +Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
On Mon, Jul 19, 2021 at 10:31 AM John Naylor <john.naylor@enterprisedb.com>
wrote:
>
> On Mon, Jul 19, 2021 at 5:44 AM Pavel Luzanov <p.luzanov@postgrespro.ru>
wrote:
> >
> > Hello,
> >
> > I found that the start section of the postgresql.conf file is missing a
> > description of two units: bytes (appeared in version 11) and
> > microseconds (in version 12).
> >
> > The attached patch makes these changes to the postgresql.conf.sample
file.
>
> Seems like an oversight. I'll commit this soon barring objections.
I pushed this and backpatched to v12. I also extracted just the "bytes"
part and applied it to v11.
--
John Naylor
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: postgresql.conf.sample missing units
2021-07-19 09:44 postgresql.conf.sample missing units Pavel Luzanov <p.luzanov@postgrespro.ru>
2021-07-19 14:31 ` Re: postgresql.conf.sample missing units John Naylor <john.naylor@enterprisedb.com>
2021-07-21 14:33 ` Re: postgresql.conf.sample missing units John Naylor <john.naylor@enterprisedb.com>
@ 2021-07-22 10:14 ` Pavel Luzanov <p.luzanov@postgrespro.ru>
0 siblings, 0 replies; 4+ messages in thread
From: Pavel Luzanov @ 2021-07-22 10:14 UTC (permalink / raw)
To: John Naylor <john.naylor@enterprisedb.com>; +Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
On 21.07.2021 17:33, John Naylor wrote:
> I pushed this and backpatched to v12. I also extracted just the
> "bytes" part and applied it to v11.
It's a little more complicated, but it's the right decision.
Thank you.
Pavel Luzanov
Postgres Professional: https://postgrespro.com
The Russian Postgres Company
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2021-07-22 10:14 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-07-19 09:44 postgresql.conf.sample missing units Pavel Luzanov <p.luzanov@postgrespro.ru>
2021-07-19 14:31 ` John Naylor <john.naylor@enterprisedb.com>
2021-07-21 14:33 ` John Naylor <john.naylor@enterprisedb.com>
2021-07-22 10:14 ` Pavel Luzanov <p.luzanov@postgrespro.ru>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox