pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: Alexey Kondratov <a.kondratov@postgrespro.ru>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Free port choosing freezes when PostgresNode::use_tcp is used on BSD systems
Date: Wed, 21 Apr 2021 10:32:40 -0400
Message-ID: <f2828ce2-e094-2291-b604-92125b68dded@dunslane.net> (raw)
In-Reply-To: <3cba5930342a51665e6959002cedb4d9@postgrespro.ru>
References: <20210127213658.GA736@alvherre.pgsql>
	<55c6c1526b94d2caf54c33262fe00674@postgrespro.ru>
	<e15777decc533006c9dbe4988bd66d31@postgrespro.ru>
	<YBTC0IYIGmyYfiIn@paquier.xyz>
	<1c506564e2a732ec17790bd8c34f042e@postgrespro.ru>
	<YBiro+n0767QDXSA@paquier.xyz>
	<YBpEsxZxIVn0zyFM@paquier.xyz>
	<66bad38beb87fb32952d89602e467444@postgrespro.ru>
	<82e271a9a11928337fcb5b5e57b423c0@postgrespro.ru>
	<459595.1618874567@sss.pgh.pa.us>
	<519ddb94-f3ac-e9cc-3a61-7003c26f62f8@dunslane.net>
	<559792.1618931011@sss.pgh.pa.us>
	<3cba5930342a51665e6959002cedb4d9@postgrespro.ru>


On 4/20/21 6:49 PM, Alexey Kondratov wrote:
> On 2021-04-20 18:03, Tom Lane wrote:
>> Andrew Dunstan <andrew@dunslane.net> writes:
>>> On 4/19/21 7:22 PM, Tom Lane wrote:
>>>> I wonder whether we could get away with just replacing the $use_tcp
>>>> test with $TestLib::windows_os.  It's not really apparent to me
>>>> why we should care about 127.0.0.not-1 on Unix-oid systems.
>>
>>> Yeah
>>> The comment is a bit strange anyway - Cygwin is actually going to use
>>> Unix sockets, not TCP.
>>> I think I would just change the test to this: $use_tcp &&
>>> $TestLib::windows_os.
>>
>> Works for me, but we need to revise the comment to match.
>>
>
> Then it could be somewhat like that, I guess.
>
>
>


pushed with slight edits.


Thanks.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com






view thread (6+ messages)

Message-ID: <f2828ce2-e094-2291-b604-92125b68dded@dunslane.net>
Permalink:  ../f2828ce2-e094-2291-b604-92125b68dded@dunslane.net/
Also on:    postgresql.org/message-id/f2828ce2-e094-2291-b604-92125b68dded@dunslane.net

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: andrew@dunslane.net, a.kondratov@postgrespro.ru, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
  Subject: Re: Free port choosing freezes when PostgresNode::use_tcp is used on BSD systems
  In-Reply-To: <f2828ce2-e094-2291-b604-92125b68dded@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox