From: Vik Fearing <vik.fearing@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Fix for FETCH FIRST syntax problems
Date: Sun, 20 May 2018 13:07:04 +0200
Message-ID: <f5cc6e99-cdf5-9fc6-ddbc-91b916877d33@2ndquadrant.com> (raw)
In-Reply-To: <25267.1526773270@sss.pgh.pa.us>
References: <877enz476l.fsf@news-spur.riddles.org.uk>
<22981.1526770675@sss.pgh.pa.us>
<03da97fc-9d6b-cbe1-c28f-cee7c1ba5c38@2ndquadrant.com>
<25267.1526773270@sss.pgh.pa.us>
On 20/05/18 01:41, Tom Lane wrote:
> Vik Fearing <vik.fearing@2ndquadrant.com> writes:
>> On 20/05/18 00:57, Tom Lane wrote:
>> I'm +1 for backpatching it. It may be operating as designed by PeterE
>> ten years ago, but it's not operating as designed by the SQL standard.
>
> By that argument, *anyplace* where we're missing a SQL-spec feature
> is a back-patchable bug. I don't buy it.
Only features we claim to support. I obviously wouldn't consider
backpatching ASSERTIONs, for example.
> It may be that this fix is simple and safe enough that the risk/reward
> tradeoff favors back-patching, but I think you have to argue it as a
> favorable tradeoff rather than just saying "this isn't per standard".
> Consider: if Andrew had completely rewritten gram.y to get the same
> visible effect, would you think that was back-patchable?
Is the decision to backpatch based on behavior, or code churn?
--
Vik Fearing +33 6 46 75 15 36
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: vik.fearing@2ndquadrant.com, tgl@sss.pgh.pa.us, andrew@tao11.riddles.org.uk
Subject: Re: Fix for FETCH FIRST syntax problems
In-Reply-To: <f5cc6e99-cdf5-9fc6-ddbc-91b916877d33@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox