pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: noriyoshi.shinoda@hpe.com
Cc: rjuju123@gmail.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: Improve logging when using Huge Pages
Date: Sat, 4 Sep 2021 01:35:30 +0900
Message-ID: <f5d8ab35-a44d-2f28-b86f-cd939c1000c4@oss.nttdata.com> (raw)
In-Reply-To: <2498302.1630679233@sss.pgh.pa.us>
References: <CAOBaU_YGfFyruW4YX6++DifTtBt8bjatz0gMhaTRD=dqV3gdWg@mail.gmail.com>
	<7e5b9f6d-1db9-d1e2-3bd8-ef65f24b35be@oss.nttdata.com>
	<TU4PR8401MB1152CB4FEB99658BC6B35543EECF9@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
	<20210903.164934.1726669051525427478.horikyota.ntt@gmail.com>
	<1946f6b9-75a1-7aeb-7b06-6c018377e518@oss.nttdata.com>
	<2498302.1630679233@sss.pgh.pa.us>



On 2021/09/03 23:27, Tom Lane wrote:
> Fujii Masao <masao.fujii@oss.nttdata.com> writes:
>> IMO, if the level is promoted to LOG, the message should be updated
>> so that it follows the error message style guide. But I agree that simpler
>> message would be better in this case. So what about something like
>> the following?
> 
>> LOG: could not map anonymous shared memory (%zu bytes) with huge pages enabled
>> HINT: The server will map anonymous shared memory again with huge pages disabled.
> 
> That is not a hint.  Maybe it qualifies as errdetail, though.

Yes, agreed.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION





view thread (93+ messages)  latest in thread

Message-ID: <f5d8ab35-a44d-2f28-b86f-cd939c1000c4@oss.nttdata.com>
Permalink:  ../f5d8ab35-a44d-2f28-b86f-cd939c1000c4@oss.nttdata.com/
Also on:    postgresql.org/message-id/f5d8ab35-a44d-2f28-b86f-cd939c1000c4@oss.nttdata.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: masao.fujii@oss.nttdata.com, tgl@sss.pgh.pa.us, horikyota.ntt@gmail.com, noriyoshi.shinoda@hpe.com, rjuju123@gmail.com
  Subject: Re: Improve logging when using Huge Pages
  In-Reply-To: <f5d8ab35-a44d-2f28-b86f-cd939c1000c4@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox