From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Windows warnings from VS 2017
Date: Wed, 20 Sep 2017 18:08:58 -0400
Message-ID: <f6488a36-4702-6d50-9fb4-fee10bb49497@2ndQuadrant.com> (raw)
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
I'm working through testing the changes to allow building with Visual
Studio 2017. I've noticed that there are some warnings that we don't see
in earlier compilers.
First, it warns about a couple of unused variables at lines 4553 and
4673 of src/backend/optimizer/path/costsize.c. I think we can do a
little rearrangement to keep it happy there.
It's also warning that it will copy 16 bytes to a 13 byte structure at
lines 518, 1293 and 1294 of src/backend/commands/dbcommands.c. I haven't
seen any ill effects of this so far, but it seems to indicate that
something is possibly amiss on this compiler with the MemSet macros.
The regression tests are currently failing on my test platform (Windows
Server 2016) because it says it can't change permissions on the
testtablespace directory. I have no idea what's going on there, still
investigating.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andrew.dunstan@2ndquadrant.com
Subject: Re: Windows warnings from VS 2017
In-Reply-To: <f6488a36-4702-6d50-9fb4-fee10bb49497@2ndQuadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox