From: Vlad Lesin <vladlesin@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
To: Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>
Subject: Re: ReplicationSlotRelease() clobbers another backend's statusFlags entry
Date: Wed, 30 Sep 2026 11:34:23 +0300
Message-ID: <f98f541d-8adf-4144-9ba1-37b935e59dd6@gmail.com> (raw)
In-Reply-To: <arxj_u6un6JGDmiP@paquier.xyz>
References: <889a06dd-45fc-423b-9dd2-87d5b5dc60c6@gmail.com>
<OS7PR01MB18317763A6F0D2A2301BA99B9F58C2@OS7PR01MB18317.jpnprd01.prod.outlook.com>
<arxj_u6un6JGDmiP@paquier.xyz>
On 9/30/26 4:21 AM, Michael Paquier wrote:
>> Regarding the test, I only used to reproduce the issue but not reviewed well,
>> because not sure it's aimed to be included. It may need more polish, i.e.,
>> advance_wal() has already been defined.
>
> Regarding this part, I am unconvinced that this is worth the cycles
> spent on. I am OK to be proved wrong, but for one the test assumes
> that we could crash, which is an anti-pattern with the fix in place
> because we don't crash once the status flags are not correctly
> filtered.
Without the fix, the test fails even without the asserts from the
v2-0002 patch.
--
Best regards,
Vlad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: vladlesin@gmail.com, michael@paquier.xyz, kuroda.hayato@fujitsu.com, x4mmm@yandex-team.ru
Subject: Re: ReplicationSlotRelease() clobbers another backend's statusFlags entry
In-Reply-To: <f98f541d-8adf-4144-9ba1-37b935e59dd6@gmail.com>
References: <889a06dd-45fc-423b-9dd2-87d5b5dc60c6@gmail.com> <OS7PR01MB18317763A6F0D2A2301BA99B9F58C2@OS7PR01MB18317.jpnprd01.prod.outlook.com> <arxj_u6un6JGDmiP@paquier.xyz> <f98f541d-8adf-4144-9ba1-37b935e59dd6@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox