From: Marina Polyakova <m.polyakova@postgrespro.ru>
To: pgsql-hackers@lists.postgresql.org
Cc: Victor Wagner <v.wagner@postgrespro.ru>
Subject: pg_upgrade check fails on Solaris 10
Date: Tue, 17 Sep 2019 19:07:31 +0300
Message-ID: <feba89f89e8925b3535cb7d72b9e05e1@postgrespro.ru> (raw)
Hello, hackers!
We got an error for pg_upgrade check on the branch REL_11_STABLE (commit
40ad4202513c72f5c1beeb03e26dfbc8890770c0) on Solaris 10 because IIUC the
argument to the sed command is not enclosed in quotation marks (see
[1]):
$ gmake -C src/bin/pg_upgrade/ check
<...>
MAKE=gmake
bindir="/home/buildfarm/mpolyakova/postgrespro_REL_11_STABLE/inst/bin"
libdir="/home/buildfarm/mpolyakova/postgrespro_REL_11_STABLE/inst/lib"
EXTRA_REGRESS_OPTS="" /bin/sh test.sh --install
test.sh: MSYS/MINGW/: not found
gmake: *** [check] Error 1
gmake: Leaving directory
`/home/buildfarm/mpolyakova/postgrespro_REL_11_STABLE/src/bin/pg_upgrade'
$ sed: command garbled: s/
Attached diff.patch fixes the problem.
About the system: SunOS, Release 5.10, KernelID Generic_141444-09.
About the used shell: according to the manual, it comes from the package
SUNWcsu.
Thanks to Victor Wagner for his help to investigate this issue.
[1] $ man sh
<...>
Quoting
The following characters have a special meaning to the shell and cause
termination of a word unless quoted:
; & ( ) | ^ < > newline space tab
--
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Attachments:
[text/x-diff] diff.patch (520B, ../feba89f89e8925b3535cb7d72b9e05e1@postgrespro.ru/2-diff.patch)
download | inline diff:diff --git a/src/bin/pg_upgrade/test.sh b/src/bin/pg_upgrade/test.shindex 424d89c3feeced91531920e919a2d9e06cc4baa6..f258983b18f8276cfef3db0a425d59fead6493d9 100644--- a/src/bin/pg_upgrade/test.sh+++ b/src/bin/pg_upgrade/test.sh@@ -33,7 +33,7 @@ standard_initdb() {
# What flavor of host are we on?
# Treat MINGW* (msys1) and MSYS* (msys2) the same.
-testhost=`uname -s | sed s/^MSYS/MINGW/`+testhost=`uname -s | sed 's/^MSYS/MINGW/'`
# Establish how the server will listen for connections
case $testhost in
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: m.polyakova@postgrespro.ru, pgsql-hackers@lists.postgresql.org, v.wagner@postgrespro.ru
Subject: Re: pg_upgrade check fails on Solaris 10
In-Reply-To: <feba89f89e8925b3535cb7d72b9e05e1@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox