From: Robbie Harwood <rharwood@redhat.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH v11] GSSAPI encryption support
Date: Mon, 04 Apr 2016 16:15:19 -0400
Message-ID: <jlgh9fht9k8.fsf@thriss.redhat.com> (raw)
In-Reply-To: <CAB7nPqSwnVLci7mZ89K+oNig7QHTi9MLxYnefOmgM=Vpro96ag@mail.gmail.com>
References: <jlg1tgq1ktm.fsf@thriss.redhat.com>
<jlgh9fl3qlr.fsf@thriss.redhat.com>
<CAB7nPqSwnVLci7mZ89K+oNig7QHTi9MLxYnefOmgM=Vpro96ag@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Michael Paquier <michael.paquier@gmail.com> writes:
> On Sat, Apr 2, 2016 at 7:34 AM, Robbie Harwood <rharwood@redhat.com> wrote:
>
>> Since I still can't reproduce this locally (left a client machine and
>> a process on the same machine retrying for over an hour on your test
>> case and didn't see it), could you provide me with some more
>> information on why repalloc is complaining?
>> Is this a low memory situation where alloc might have failed?
>
> No, this is an assertion failure, and it seems that you are compiling
> this code without --enable-cassert, without the switch the code
> actually works.
You are right. I now see the assertion failure.
>> That pointer looks like it's on the heap, is that correct?
>
> appendBinaryStringInfo depends on palloc calls that allocate memory
> depending on the memory context used. It looks that what's just
> missing in your logic is a private memory context that be_gssapi_write
> and be_gssapi_read can use to handle the allocation of the
> communication buffers.
Thank you very much for the pointer! I will work in memory context
management for the next version.
Attachments:
signature.asc (application/pgp-signature, 818B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: rharwood@redhat.com, michael.paquier@gmail.com
Subject: Re: [PATCH v11] GSSAPI encryption support
In-Reply-To: <jlgh9fht9k8.fsf@thriss.redhat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox