From: Robbie Harwood <rharwood@redhat.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH v4] GSSAPI encryption support
Date: Thu, 11 Feb 2016 13:56:06 -0500
Message-ID: <jlglh6r5b5l.fsf@thriss.redhat.com> (raw)
In-Reply-To: <CAB7nPqS+zyHHE61cxy_DQnFL_Nk2N6V1w1E07bg53shm1++p-w@mail.gmail.com>
References: <jlg1tgq1ktm.fsf@thriss.redhat.com>
<jlg4mdg8ebw.fsf@thriss.redhat.com>
<CAB7nPqS+zyHHE61cxy_DQnFL_Nk2N6V1w1E07bg53shm1++p-w@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Michael Paquier <michael.paquier@gmail.com> writes:
> On Thu, Feb 11, 2016 at 6:06 AM, Robbie Harwood <rharwood@redhat.com> wrote:
>>
>> - The GSSAPI authentication code has been moved without modification.
>> In doing so, the temptation to modify it (flags, error checking, that
>> big comment at the top about things from Athena, etc.) is very large.
>> I do not know whether these changes are best suited to another patch
>> in this series or should be reviewed separately. I am also hesitant
>> to add things beyond the core before I am told this is the right
>> approach.
>
> I would recommend a different patch if code needs to be moved around.
> The move may make sense taken as an independent piece of the
> integration.
Sorry, are you suggesting separate patch for moving the GSS auth code,
or separate patch for changes to said code? I am happy to move it if
so, just want to be sure.
> + * Portions Copyright (c) 2015-2016, Red Hat, Inc.
> + * Portions Copyright (c) 1996-2016, PostgreSQL Global Development Group
> I think that this part may be a problem... Not sure the feeling of the
> others regarding additional copyright notices.
Good catch. That's an accident (force of habit). Since I'm pretty sure
this version won't be merged anyway, I'll drop it from the next one.
> It would be good to add that to the next CF, I will be happy to get a
> look at it.
Sounds good. Thanks for looking at it!
Attachments:
signature.asc (application/pgp-signature, 818B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: rharwood@redhat.com, michael.paquier@gmail.com
Subject: Re: [PATCH v4] GSSAPI encryption support
In-Reply-To: <jlglh6r5b5l.fsf@thriss.redhat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox