pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Dimitri Fontaine <dimitri@2ndQuadrant.fr>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Event Triggers: adding information
Date: Sun, 30 Dec 2012 13:18:32 +0100
Message-ID: <m28v8fn36v.fsf@2ndQuadrant.fr> (raw)
In-Reply-To: <1356840827.20017.15.camel@vanquo.pezone.net>
References: <m2txrsdzxa.fsf@2ndQuadrant.fr>
	<m2zk1j9c44.fsf@2ndQuadrant.fr>
	<CA+Tgmob6kmAySE5yXvd3uE9LifHunufMg9iU3GmbJ5bpGPiHjQ@mail.gmail.com>
	<m2k3sbe51z.fsf@2ndQuadrant.fr>
	<CA+TgmoZjOACnHOKrz-eucj3FJXrYJzA-_yjSqajOQR8qkjCi=w@mail.gmail.com>
	<m2bodi55yn.fsf@2ndQuadrant.fr>
	<CA+TgmoZTxXGAkoyQD0aNOyju1X19SnVfk7KV9fsJCv63bS-C4g@mail.gmail.com>
	<1356840827.20017.15.camel@vanquo.pezone.net>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Hi,

Peter Eisentraut <peter_e@gmx.net> writes:
> There is a new compiler warning coming from this, I believe:

I don't get this warning here, at least not in -O2, and I did forget to
make maintainer-clean then rebuild with -O0 just in case gcc is now
complaining about something else. I wish this situation could be fixed.

Now, this warning needs to be fixed, too, and here's a patch for that.

Thanks, regards,
-- 
Dimitri Fontaine
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachments:

copy-warning-fix.patch (text/x-patch, 486B) download
diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.c
index 31a0288..00f859e 100644
--- a/src/backend/commands/copy.c
+++ b/src/backend/commands/copy.c
@@ -750,7 +750,7 @@ DoCopy(const CopyStmt *stmt, const char *queryString, uint64 *processed)
 	bool		is_from = stmt->is_from;
 	bool		pipe = (stmt->filename == NULL);
 	Relation	rel;
-	Oid         relid;
+	Oid         relid = InvalidOid;
 
 	/* Disallow file COPY except to superusers. */
 	if (!pipe && !superuser())

view thread (114+ messages)  latest in thread

Message-ID: <m28v8fn36v.fsf@2ndQuadrant.fr>
Permalink:  ../m28v8fn36v.fsf@2ndQuadrant.fr/
Also on:    postgresql.org/message-id/m28v8fn36v.fsf@2ndQuadrant.fr

copy link · copy postgr.es · copy git am

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: dimitri@2ndQuadrant.fr, peter_e@gmx.net, robertmhaas@gmail.com
  Subject: Re: Event Triggers: adding information
  In-Reply-To: <m28v8fn36v.fsf@2ndQuadrant.fr>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox