pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Dimitri Fontaine <dimitri@2ndQuadrant.fr>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Event Triggers: adding information
Date: Wed, 23 Jan 2013 10:57:52 +0100
Message-ID: <m2zk00cjbz.fsf@2ndQuadrant.fr> (raw )
In-Reply-To: <CA+TgmoYgpub59RrQ+n=qoejmADhj-kppCfDgQjWP+rR+8m+39Q@mail.gmail.com >
References: <m2txrsdzxa.fsf@2ndQuadrant.fr >
<m2k3sbe51z.fsf@2ndQuadrant.fr >
<CA+TgmoZjOACnHOKrz-eucj3FJXrYJzA-_yjSqajOQR8qkjCi=w@mail.gmail.com >
<m2bodi55yn.fsf@2ndQuadrant.fr >
<CA+TgmoZTxXGAkoyQD0aNOyju1X19SnVfk7KV9fsJCv63bS-C4g@mail.gmail.com >
<m27go1ot1a.fsf@2ndQuadrant.fr >
<20130104205251.GB9191@alvh.no-ip.org >
<m28v88pqin.fsf@2ndQuadrant.fr >
<20130109165829.GB4490@alvh.no-ip.org >
<CA+TgmobykpymdGyfbCDEfS6+-50X-AKYTdK88fjMS4-mY5SBdw@mail.gmail.com >
<m2ehhkrfqk.fsf@2ndQuadrant.fr >
<CA+TgmobfeB_YpgMv5NjW52tG36Hg_DY=jq0XDkE5zwCstPQ4pg@mail.gmail.com >
<m2pq14m7sx.fsf@2ndQuadrant.fr >
<CA+TgmoYEW583z+oisToCYQMz2grzpavdXrCi3-W2D_+nucVhzQ@mail.gmail.com >
<m2k3rbhh79.fsf@2ndQuadrant.fr >
<CA+TgmoZYFhn=DyenBLr8KUZXYHtgjo-O8YE-7y61WKR6F05UQA@mail.gmail.com >
<m21udesaz3.fsf@2ndQuadrant.fr >
<CA+TgmoZPhj6Rw-DottwresCJnOmRewbOxp2AABwyxP2k7vZf-Q@mail.gmail.com >
<m2622pmnnn.fsf@2ndQuadrant.fr >
<m2vcapl7tl.fsf@2ndQuadrant.fr >
<CA+TgmoYgpub59RrQ+n=qoejmADhj-kppCfDgQjWP+rR+8m+39Q@mail.gmail.com >
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Robert Haas <robertmhaas@gmail.com> writes:
> I think these new regression tests are no good, because I doubt that
> the number of recursive calls that can fit into any given amount of
> stack space is guaranteed to be the same on all platforms. I have
> committed the bug fixes themselves, however.
Thanks for commiting the fixes. About the regression tests, I think
you're right, but then I can't see how to include such a test. Maybe you
could add the other one, though?
> I wasn't entirely happy with your proposed documentation so I'm
> attaching a counter-proposal. My specific complaints are (1) telling
> people that event triggers are run in a savepoint seems a little too
> abstract; I have attempted to make the consequences more concrete; (2)
> RAISE EXCEPTION is PL/pgsql specific and not the only possible reason
> for an error; I have attempted to be more generic; and (3) in the
> process of fiddling with this, I noticed that the ddl_command_end
> documentation can, I believe, be made both shorter and more clear by
> turning it into a rider on the previous paragraph.
>
> Comments?
+1 for this version, thanks.
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
view thread (114+ messages) latest in thread
Message-ID: <m2zk00cjbz.fsf@2ndQuadrant.fr>
Permalink: ../m2zk00cjbz.fsf@2ndQuadrant.fr/
Also on: postgresql.org/message-id/m2zk00cjbz.fsf@2ndQuadrant.fr
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: dimitri@2ndQuadrant.fr, robertmhaas@gmail.com, alvherre@2ndquadrant.com
Subject: Re: Event Triggers: adding information
In-Reply-To: <m2zk00cjbz.fsf@2ndQuadrant.fr>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox