agora inbox for [email protected]  

help / color / mirror / Atom feed

Re: [PATCH] get rid of StdRdOptions, use individual binary reloptions representation for each relation kind instead
968+ messages / 3 participants
[nested] [flat]

* Re: [PATCH] get rid of StdRdOptions, use individual binary reloptions representation for each relation kind instead
@ 2019-08-01 09:39 Thomas Munro <[email protected]>
  2019-09-27 08:24 ` Re: [PATCH] get rid of StdRdOptions, use individual binary reloptions representation for each relation kind instead Michael Paquier <[email protected]>
  0 siblings, 1 reply; 968+ messages in thread

From: Thomas Munro @ 2019-08-01 09:39 UTC (permalink / raw)
  To: Tomas Vondra <[email protected]>; +Cc: Nikolay Shaplov <[email protected]>; PostgreSQL Hackers <[email protected]>; Dent John <[email protected]>; Iwata, Aya <[email protected]>; Alvaro Herrera <[email protected]>; Dmitry Dolgov <[email protected]>

On Sat, Jul 13, 2019 at 2:14 AM Nikolay Shaplov <[email protected]> wrote:
> Here goes an updated version.

On Sat, Jul 20, 2019 at 8:21 PM Dent John <[email protected]> wrote:
> [review]

On Sun, Jul 28, 2019 at 5:38 AM Tomas Vondra
<[email protected]> wrote:
> [review]

Hi Nikolay,

Looks like some good actionable feedback.  I've moved this patch to
September, and set it to "Waiting on Author".

-- 
Thomas Munro
https://enterprisedb.com





^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* Re: [PATCH] get rid of StdRdOptions, use individual binary reloptions representation for each relation kind instead
  2019-08-01 09:39 Re: [PATCH] get rid of StdRdOptions, use individual binary reloptions representation for each relation kind instead Thomas Munro <[email protected]>
@ 2019-09-27 08:24 ` Michael Paquier <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Michael Paquier @ 2019-09-27 08:24 UTC (permalink / raw)
  To: Thomas Munro <[email protected]>; +Cc: Tomas Vondra <[email protected]>; Nikolay Shaplov <[email protected]>; PostgreSQL Hackers <[email protected]>; Dent John <[email protected]>; Iwata, Aya <[email protected]>; Alvaro Herrera <[email protected]>; Dmitry Dolgov <[email protected]>

On Thu, Aug 01, 2019 at 09:39:53PM +1200, Thomas Munro wrote:
> Looks like some good actionable feedback.  I've moved this patch to
> September, and set it to "Waiting on Author".

The patch is in this state for two months now, so I have switched it
to "returned with feedback".  The latest patch does not apply, and it
would require an update for the new test module dummy_index_am.

As I have touched recently in the area of the code, I got a look at it
and the core of the idea is that it would be cleaner to move the
control of reloptions from reloptions.c to each AM, as well as have an
extra later for toast.  This has additional costs in multiple ways:
- The parsing and filling of reloptions gets more duplicated, though
this could be solved with a wrapper routine (something HEAD already
does when filling in rd_options).
- Logic which was out of toast previously is not anymore.

Some of these have been mentioned by Tomas upthread, and I share
similar points.  I also doubt that the removal of
RelationGetTargetPageFreeSpace() is a good thing, and this complicates
more the checks around options and the handling of rd_options which
may become optionally NULL, making a bit more brittle the whole
structure.  We may be able to get useful pieces for it, though it is
not clear what would be the benefits.  It may help as well to group
that within the thread dedicated to the rework of the reloption APIs
as a preliminary, refactoring step.
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, ../../[email protected]/2-signature.asc)
  download

^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread

* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple?
@ 2026-03-12 15:14 Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 968+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw)

---
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 73aa6f0589c..c77564c4024 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 		attrs = palloc_array(Datum, desc->natts);
 		isnull = palloc_array(bool, desc->natts);
 
+		/*
+		 * XXX it might be better to use slot_deform_tuple here, for the case
+		 * where atttributes near the end of the tuple don't need to undergo
+		 * this procedure.
+		 */
 		heap_deform_tuple(tuple, desc, attrs, isnull);
 
-		/* First, gather and count the "external indirect" attributes. */
+		/* First, gather all the "external indirect" attributes. */
 		for (int i = 0; i < desc->natts; i++)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 968+ messages in thread