agora inbox for [email protected]help / color / mirror / Atom feed
Shouldn't flush dirty buffers at shutdown ? 970+ messages / 3 participants [nested] [flat]
* Shouldn't flush dirty buffers at shutdown ? @ 2000-05-09 14:34 Hiroshi Inoue <[email protected]> 0 siblings, 1 reply; 970+ messages in thread From: Hiroshi Inoue @ 2000-05-09 14:34 UTC (permalink / raw) To: pgsql-hackers Hi all, While testing vacuum,I noticed that dirty buffers aren't necessarily written to disk in case of abort. In addtion they have no guarantee to be flushed before the shutdown of postmaster. The recent bufmgr changes seems to have increased the possibility much more than before. Certainly it's not bad unless there are indexes. However if heap data wasn't flushed while corresponding indices are written to disk,the indices would point to non-existence heap block. It would be the cause of inconsistency after the restart of postmaster. Shouldn't there be a mechanism to flush dirty buffers at(or before) the shutdown of postmaster ? Comments ? Regards. Hiroshi Inoue [email protected] ^ permalink raw reply [nested|flat] 970+ messages in thread
* Re: Shouldn't flush dirty buffers at shutdown ? @ 2000-05-09 14:49 Tom Lane <[email protected]> parent: Hiroshi Inoue <[email protected]> 0 siblings, 1 reply; 970+ messages in thread From: Tom Lane @ 2000-05-09 14:49 UTC (permalink / raw) To: Hiroshi Inoue <[email protected]>; +Cc: pgsql-hackers "Hiroshi Inoue" <[email protected]> writes: > if heap data wasn't flushed while corresponding indices > are written to disk,the indices would point to non-existence > heap block. It would be the cause of inconsistency after the > restart of postmaster. Shouldn't there be a mechanism to > flush dirty buffers at(or before) the shutdown of postmaster ? Hmm, good point, but that doesn't seem like the right answer. Suppose the system crashes before we are able to flush the dirty buffers? I think you have identified a problem that needs a more general solution: we need to be robust in the case that an index entry is on disk that points to a tuple that never made it to disk. We can legitimately assume that the tuple is uncommitted and ignore the index entry --- we just have to not fail ;-) Not sure how to do it offhand; maybe some additional checking in the index fetch code will do? regards, tom lane ^ permalink raw reply [nested|flat] 970+ messages in thread
* RE: Shouldn't flush dirty buffers at shutdown ? @ 2000-05-09 17:14 Hiroshi Inoue <[email protected]> parent: Tom Lane <[email protected]> 0 siblings, 1 reply; 970+ messages in thread From: Hiroshi Inoue @ 2000-05-09 17:14 UTC (permalink / raw) To: Tom Lane <[email protected]>; +Cc: pgsql-hackers > -----Original Message----- > From: Tom Lane [mailto:[email protected]] > Sent: Tuesday, May 09, 2000 11:50 PM > > "Hiroshi Inoue" <[email protected]> writes: > > if heap data wasn't flushed while corresponding indices > > are written to disk,the indices would point to non-existence > > heap block. It would be the cause of inconsistency after the > > restart of postmaster. Shouldn't there be a mechanism to > > flush dirty buffers at(or before) the shutdown of postmaster ? > > Hmm, good point, but that doesn't seem like the right answer. > Suppose the system crashes before we are able to flush the > dirty buffers? You are right but we could hardly expect the completeness of indexes in case of system crash because indexes are out of transactional control currently. What surprized me was that such problems could easily occur even in case of graceful shutdown of postmaster. > I think you have identified a problem that needs > a more general solution: we need to be robust in the case that > an index entry is on disk that points to a tuple that never made > it to disk. Probably an index entry that points to a non-existent heap block doesn't cause a problem immediately because heap_ fetch() ignores UNUSED heap blocks. However it will not be long before the heap block is filled with another tuple. heap_insert/update() could hardly check that the inserting heap block is already pointed from some index entry. There could be another case which I came across while testing vacuum abort. i.e,index_delete() wasn't flushed while the corresponding heap block is cleaned(set to UNUSED) and flushed. Regards. Hiroshi Inoue [email protected] ^ permalink raw reply [nested|flat] 970+ messages in thread
* Re: Shouldn't flush dirty buffers at shutdown ? @ 2000-05-09 17:20 Tom Lane <[email protected]> parent: Hiroshi Inoue <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Tom Lane @ 2000-05-09 17:20 UTC (permalink / raw) To: Hiroshi Inoue <[email protected]>; +Cc: pgsql-hackers "Hiroshi Inoue" <[email protected]> writes: >> Hmm, good point, but that doesn't seem like the right answer. >> Suppose the system crashes before we are able to flush the >> dirty buffers? > You are right but we could hardly expect the completeness > of indexes in case of system crash because indexes are out > of transactional control currently. What? We do flush the index blocks before committing, just the same as heap blocks, so I do not see the risk there. If we have committed a tuple then its index entries should be on disk too. The risk I think you have shown is that there may be extra index entries that correspond to no tuple because we wrote the index blocks first and then crashed before writing the tuple. > Probably an index entry that points to a non-existent heap > block doesn't cause a problem immediately because heap_ > fetch() ignores UNUSED heap blocks. > However it will not be long before the heap block is filled with > another tuple. heap_insert/update() could hardly check that > the inserting heap block is already pointed from some index > entry. Yes. We need some way of cross-checking that an index entry actually does match the tuple it thinks it's pointing at. The first thought that comes to mind is that the index tuple should contain the OID of the tuple it is for, and then we can check that against the pointed-to tuple. If they don't match, the index entry is bogus and can be discarded at the next VACUUM. regards, tom lane ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
* [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? @ 2026-03-12 15:14 Álvaro Herrera <[email protected]> 0 siblings, 0 replies; 970+ messages in thread From: Álvaro Herrera @ 2026-03-12 15:14 UTC (permalink / raw) --- src/backend/replication/pgoutput_repack/pgoutput_repack.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c index 73aa6f0589c..c77564c4024 100644 --- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c +++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c @@ -200,9 +200,14 @@ store_change(LogicalDecodingContext *ctx, Relation relation, attrs = palloc_array(Datum, desc->natts); isnull = palloc_array(bool, desc->natts); + /* + * XXX it might be better to use slot_deform_tuple here, for the case + * where atttributes near the end of the tuple don't need to undergo + * this procedure. + */ heap_deform_tuple(tuple, desc, attrs, isnull); - /* First, gather and count the "external indirect" attributes. */ + /* First, gather all the "external indirect" attributes. */ for (int i = 0; i < desc->natts; i++) { CompactAttribute *attr = TupleDescCompactAttr(desc, i); -- 2.47.3 --pnppmxqkefjd4hu2 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0009-reuse-existing-variable-by-overwriting-it.nocfbot.txt" ^ permalink raw reply [nested|flat] 970+ messages in thread
end of thread, other threads:[~2026-03-12 15:14 UTC | newest] Thread overview: 970+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2000-05-09 14:34 Shouldn't flush dirty buffers at shutdown ? Hiroshi Inoue <[email protected]> 2000-05-09 14:49 ` Tom Lane <[email protected]> 2000-05-09 17:14 ` Hiroshi Inoue <[email protected]> 2000-05-09 17:20 ` Tom Lane <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]> 2026-03-12 15:14 [PATCH 8/9] XXX devel comment: heap_deform_tuple -> slot_deform_tuple? Álvaro Herrera <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox