public inbox for [email protected]help / color / mirror / Atom feed
[PATCH 14/21] doc review: logical decode in prepare 28+ messages / 3 participants [nested] [flat]
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 28+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 14/21] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 28+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --jI8keyz6grp/JLjh Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 28+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 28+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 28+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 28+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 28+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 28+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 28+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 28+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 28+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 28+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 28+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 28+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 28+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 28+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 28+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 28+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 28+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 28+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 28+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 28+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 28+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 28+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 28+ messages in thread
* Re: pgsql: Server-side gzip compression. @ 2022-01-25 09:19 David Rowley <[email protected]> 2022-01-25 18:12 ` Re: pgsql: Server-side gzip compression. Robert Haas <[email protected]> 0 siblings, 1 reply; 28+ messages in thread From: David Rowley @ 2022-01-25 09:19 UTC (permalink / raw) To: Robert Haas <[email protected]>; +Cc: [email protected] On Tue, 25 Jan 2022 at 09:14, Robert Haas <[email protected]> wrote: > src/backend/replication/basebackup_gzip.c | 309 ++++++++++++++++++++++++++++++ This could do with the attached. MSVC compilers need a bit more reassurance that ereport/elog ERRORs don't return. David Attachments: [application/octet-stream] fix_basebackup_gzip_compiler_warning.patch (500B, ../../CAApHDvosHkgyo_PZs7CSB4Kgs2ey4FdmFpcK0N_QOci9DJ=wnw@mail.gmail.com/2-fix_basebackup_gzip_compiler_warning.patch) download | inline diff: diff --git a/src/backend/replication/basebackup_gzip.c b/src/backend/replication/basebackup_gzip.c index 1e58382fa0..b66d3da7a3 100644 --- a/src/backend/replication/basebackup_gzip.c +++ b/src/backend/replication/basebackup_gzip.c @@ -66,6 +66,7 @@ bbsink_gzip_new(bbsink *next, int compresslevel) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("gzip compression is not supported by this build"))); + return NULL; /* keep compiler quiet */ #else bbsink_gzip *sink; ^ permalink raw reply [nested|flat] 28+ messages in thread
* Re: pgsql: Server-side gzip compression. 2022-01-25 09:19 Re: pgsql: Server-side gzip compression. David Rowley <[email protected]> @ 2022-01-25 18:12 ` Robert Haas <[email protected]> 2022-01-25 20:56 ` Re: pgsql: Server-side gzip compression. David Rowley <[email protected]> 0 siblings, 1 reply; 28+ messages in thread From: Robert Haas @ 2022-01-25 18:12 UTC (permalink / raw) To: David Rowley <[email protected]>; +Cc: PostgreSQL Hackers <[email protected]> On Tue, Jan 25, 2022 at 4:20 AM David Rowley <[email protected]> wrote: > On Tue, 25 Jan 2022 at 09:14, Robert Haas <[email protected]> wrote: > > src/backend/replication/basebackup_gzip.c | 309 ++++++++++++++++++++++++++++++ > > This could do with the attached. MSVC compilers need a bit more > reassurance that ereport/elog ERRORs don't return. Err, well, if we need it, we need it. It surprises me, though: wouldn't this same consideration apply to a very large number of other places in the code base? -- Robert Haas EDB: http://www.enterprisedb.com ^ permalink raw reply [nested|flat] 28+ messages in thread
* Re: pgsql: Server-side gzip compression. 2022-01-25 09:19 Re: pgsql: Server-side gzip compression. David Rowley <[email protected]> 2022-01-25 18:12 ` Re: pgsql: Server-side gzip compression. Robert Haas <[email protected]> @ 2022-01-25 20:56 ` David Rowley <[email protected]> 2022-01-27 19:43 ` Re: pgsql: Server-side gzip compression. Robert Haas <[email protected]> 0 siblings, 1 reply; 28+ messages in thread From: David Rowley @ 2022-01-25 20:56 UTC (permalink / raw) To: Robert Haas <[email protected]>; +Cc: PostgreSQL Hackers <[email protected]> On Wed, 26 Jan 2022 at 07:12, Robert Haas <[email protected]> wrote: > wouldn't this same consideration apply to a very large number of other > places in the code base? All of the other places are handled. See locations with "keep compiler quiet". This one is the only one that generates a warning: basebackup_gzip.c(90): warning C4715: 'bbsink_gzip_new': not all control paths return a value David ^ permalink raw reply [nested|flat] 28+ messages in thread
* Re: pgsql: Server-side gzip compression. 2022-01-25 09:19 Re: pgsql: Server-side gzip compression. David Rowley <[email protected]> 2022-01-25 18:12 ` Re: pgsql: Server-side gzip compression. Robert Haas <[email protected]> 2022-01-25 20:56 ` Re: pgsql: Server-side gzip compression. David Rowley <[email protected]> @ 2022-01-27 19:43 ` Robert Haas <[email protected]> 2022-01-31 04:07 ` Re: pgsql: Server-side gzip compression. David Rowley <[email protected]> 0 siblings, 1 reply; 28+ messages in thread From: Robert Haas @ 2022-01-27 19:43 UTC (permalink / raw) To: David Rowley <[email protected]>; +Cc: PostgreSQL Hackers <[email protected]> On Tue, Jan 25, 2022 at 3:56 PM David Rowley <[email protected]> wrote: > On Wed, 26 Jan 2022 at 07:12, Robert Haas <[email protected]> wrote: > > wouldn't this same consideration apply to a very large number of other > > places in the code base? > > All of the other places are handled. See locations with "keep compiler quiet". > > This one is the only one that generates a warning: > > basebackup_gzip.c(90): warning C4715: 'bbsink_gzip_new': not all > control paths return a value OK. I'm still surprised, but it is what it is. I've committed this now. FWIW, I would have been fine with you just committing this change. I can't see the warning locally, so I'm not in a position to second-guess your statement that it's needed. Thanks, -- Robert Haas EDB: http://www.enterprisedb.com ^ permalink raw reply [nested|flat] 28+ messages in thread
* Re: pgsql: Server-side gzip compression. 2022-01-25 09:19 Re: pgsql: Server-side gzip compression. David Rowley <[email protected]> 2022-01-25 18:12 ` Re: pgsql: Server-side gzip compression. Robert Haas <[email protected]> 2022-01-25 20:56 ` Re: pgsql: Server-side gzip compression. David Rowley <[email protected]> 2022-01-27 19:43 ` Re: pgsql: Server-side gzip compression. Robert Haas <[email protected]> @ 2022-01-31 04:07 ` David Rowley <[email protected]> 0 siblings, 0 replies; 28+ messages in thread From: David Rowley @ 2022-01-31 04:07 UTC (permalink / raw) To: Robert Haas <[email protected]>; +Cc: PostgreSQL Hackers <[email protected]> On Fri, 28 Jan 2022 at 08:44, Robert Haas <[email protected]> wrote: > OK. I'm still surprised, but it is what it is. I've committed this now. Thanks > FWIW, I would have been fine with you just committing this change. That's good to know, thanks for mentioning it. FWIW, I just held back as I wasn't 100% sure on the etiquette. David ^ permalink raw reply [nested|flat] 28+ messages in thread
end of thread, other threads:[~2022-01-31 04:07 UTC | newest] Thread overview: 28+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/21] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2022-01-25 09:19 Re: pgsql: Server-side gzip compression. David Rowley <[email protected]> 2022-01-25 18:12 ` Re: pgsql: Server-side gzip compression. Robert Haas <[email protected]> 2022-01-25 20:56 ` Re: pgsql: Server-side gzip compression. David Rowley <[email protected]> 2022-01-27 19:43 ` Re: pgsql: Server-side gzip compression. Robert Haas <[email protected]> 2022-01-31 04:07 ` Re: pgsql: Server-side gzip compression. David Rowley <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox