public inbox for [email protected]help / color / mirror / Atom feed
[PATCH 14/21] doc review: logical decode in prepare 30+ messages / 6 participants [nested] [flat]
* [PATCH 14/21] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 30+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --jI8keyz6grp/JLjh Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 30+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 30+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 30+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 30+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 30+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 30+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 30+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 30+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 30+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 30+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 30+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 30+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 30+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 30+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 30+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 30+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 30+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 30+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 30+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 30+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 30+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 30+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 30+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 30+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 30+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 30+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 30+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 30+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 30+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 30+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 30+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 30+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 30+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 30+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 30+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 30+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 30+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 30+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 30+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 30+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 30+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 30+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 30+ messages in thread
* [PATCH 14/18] doc review: logical decode in prepare @ 2021-01-24 02:33 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 30+ messages in thread From: Justin Pryzby @ 2021-01-24 02:33 UTC (permalink / raw) a271a1b50e9bec07e2ef3a05e38e7285113e4ce6 --- doc/src/sgml/logicaldecoding.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/logicaldecoding.sgml b/doc/src/sgml/logicaldecoding.sgml index cf705ed9cd..b854f2ccfc 100644 --- a/doc/src/sgml/logicaldecoding.sgml +++ b/doc/src/sgml/logicaldecoding.sgml @@ -1214,7 +1214,7 @@ stream_commit_cb(...); <-- commit of the streamed transaction </para> <para> - When a prepared transaction is rollbacked using the + When a prepared transaction is rolled back using the <command>ROLLBACK PREPARED</command>, then the <function>rollback_prepared_cb</function> callback is invoked and when the prepared transaction is committed using <command>COMMIT PREPARED</command>, -- 2.17.0 --lc9FT7cWel8HagAv Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0015-doc-review-for-multiranges.patch" ^ permalink raw reply [nested|flat] 30+ messages in thread
* pgsql: Add ALTER SUBSCRIPTION ... SKIP. @ 2022-03-22 01:56 Amit Kapila <[email protected]> 0 siblings, 2 replies; 30+ messages in thread From: Amit Kapila @ 2022-03-22 01:56 UTC (permalink / raw) To: [email protected] Add ALTER SUBSCRIPTION ... SKIP. This feature allows skipping the transaction on subscriber nodes. If incoming change violates any constraint, logical replication stops until it's resolved. Currently, users need to either manually resolve the conflict by updating a subscriber-side database or by using function pg_replication_origin_advance() to skip the conflicting transaction. This commit introduces a simpler way to skip the conflicting transactions. The user can specify LSN by ALTER SUBSCRIPTION ... SKIP (lsn = XXX), which allows the apply worker to skip the transaction finished at specified LSN. The apply worker skips all data modification changes within the transaction. Author: Masahiko Sawada Reviewed-by: Takamichi Osumi, Hou Zhijie, Peter Eisentraut, Amit Kapila, Shi Yu, Vignesh C, Greg Nancarrow, Haiying Tang, Euler Taveira Discussion: https://postgr.es/m/CAD21AoDeScrsHhLyEPYqN3sydg6PxAPVBboK=30xJfUVihNZDA@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/208c5d65bbd60e33e272964578cb74182ac726a8 Modified Files -------------- doc/src/sgml/catalogs.sgml | 10 + doc/src/sgml/logical-replication.sgml | 27 +-- doc/src/sgml/ref/alter_subscription.sgml | 42 +++++ src/backend/catalog/pg_subscription.c | 1 + src/backend/catalog/system_views.sql | 2 +- src/backend/commands/subscriptioncmds.c | 73 ++++++++ src/backend/parser/gram.y | 9 + src/backend/replication/logical/worker.c | 233 +++++++++++++++++++++++- src/bin/pg_dump/pg_dump.c | 4 + src/bin/psql/describe.c | 8 +- src/bin/psql/tab-complete.c | 5 +- src/include/catalog/catversion.h | 2 +- src/include/catalog/pg_subscription.h | 5 + src/include/nodes/parsenodes.h | 3 +- src/test/regress/expected/subscription.out | 126 +++++++------ src/test/regress/sql/subscription.sql | 11 ++ src/test/subscription/t/029_disable_on_error.pl | 94 ---------- src/test/subscription/t/029_on_error.pl | 183 +++++++++++++++++++ 18 files changed, 665 insertions(+), 173 deletions(-) ^ permalink raw reply [nested|flat] 30+ messages in thread
* Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP. @ 2022-03-22 23:59 Andres Freund <[email protected]> parent: Amit Kapila <[email protected]> 1 sibling, 1 reply; 30+ messages in thread From: Andres Freund @ 2022-03-22 23:59 UTC (permalink / raw) To: Amit Kapila <[email protected]>; +Cc: [email protected] Hi, On 2022-03-22 01:56:03 +0000, Amit Kapila wrote: > Add ALTER SUBSCRIPTION ... SKIP. > > This feature allows skipping the transaction on subscriber nodes. > > If incoming change violates any constraint, logical replication stops > until it's resolved. Currently, users need to either manually resolve the > conflict by updating a subscriber-side database or by using function > pg_replication_origin_advance() to skip the conflicting transaction. This > commit introduces a simpler way to skip the conflicting transactions. > > The user can specify LSN by ALTER SUBSCRIPTION ... SKIP (lsn = XXX), > which allows the apply worker to skip the transaction finished at > specified LSN. The apply worker skips all data modification changes within > the transaction. This was missing an include of xlogdefs.h in pg_subscription.h, thus failing in headerscheck. See e.g. https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2022-03-22%2022%3A22%3A05 I've pushed the trivial fix for that. I'll propose adding headerscheck to CI / cfbot. Greetings, Andres Freund ^ permalink raw reply [nested|flat] 30+ messages in thread
* Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP. @ 2022-03-23 01:56 Amit Kapila <[email protected]> parent: Andres Freund <[email protected]> 0 siblings, 0 replies; 30+ messages in thread From: Amit Kapila @ 2022-03-23 01:56 UTC (permalink / raw) To: Andres Freund <[email protected]>; +Cc: Amit Kapila <[email protected]>; pgsql-committers <[email protected]> On Wed, Mar 23, 2022 at 5:29 AM Andres Freund <[email protected]> wrote: > > Hi, > > On 2022-03-22 01:56:03 +0000, Amit Kapila wrote: > > Add ALTER SUBSCRIPTION ... SKIP. > > > > This feature allows skipping the transaction on subscriber nodes. > > > > If incoming change violates any constraint, logical replication stops > > until it's resolved. Currently, users need to either manually resolve the > > conflict by updating a subscriber-side database or by using function > > pg_replication_origin_advance() to skip the conflicting transaction. This > > commit introduces a simpler way to skip the conflicting transactions. > > > > The user can specify LSN by ALTER SUBSCRIPTION ... SKIP (lsn = XXX), > > which allows the apply worker to skip the transaction finished at > > specified LSN. The apply worker skips all data modification changes within > > the transaction. > > This was missing an include of xlogdefs.h in pg_subscription.h, thus failing > in headerscheck. See e.g. > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2022-03-22%2022%3A22%3A05 > > I've pushed the trivial fix for that. I'll propose adding headerscheck to CI / > cfbot. > Thanks. -- With Regards, Amit Kapila. ^ permalink raw reply [nested|flat] 30+ messages in thread
* Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP. @ 2022-09-04 08:18 Alvaro Herrera <[email protected]> parent: Amit Kapila <[email protected]> 1 sibling, 1 reply; 30+ messages in thread From: Alvaro Herrera @ 2022-09-04 08:18 UTC (permalink / raw) To: Amit Kapila <[email protected]>; Masahiko Sawada <[email protected]>; +Cc: [email protected] On 2022-Mar-22, Amit Kapila wrote: > Add ALTER SUBSCRIPTION ... SKIP. There are two messages here that seem oddly worded. msgid "start skipping logical replication transaction finished at %X/%X" msgid "done skipping logical replication transaction finished at %X/%X" Two complaints here. First, the phrases "start / finished" and "done / finished" look very strange. It took me a while to realize that "finished" refers to the LSN, not to the skipping operation. Do we ever talk about a transaction "finished at XYZ" as opposed to a transaction whose LSN is XYZ? (This became particularly strange when I realized that the LSN might come from a PREPARE.) Second, "logical replication transaction". Is it not a regular transaction that we happen to be processing via logical replication? I think they should say something like "logical replication starts skipping transaction with LSN %X/%X" "logical replication completed skipping transaction with LSN %X/%X" Other ideas? -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ Officer Krupke, what are we to do? Gee, officer Krupke, Krup you! (West Side Story, "Gee, Officer Krupke") ^ permalink raw reply [nested|flat] 30+ messages in thread
* Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP. @ 2022-09-04 11:38 Amit Kapila <[email protected]> parent: Alvaro Herrera <[email protected]> 0 siblings, 1 reply; 30+ messages in thread From: Amit Kapila @ 2022-09-04 11:38 UTC (permalink / raw) To: Alvaro Herrera <[email protected]>; +Cc: Amit Kapila <[email protected]>; Masahiko Sawada <[email protected]>; [email protected] On Sun, Sep 4, 2022 at 1:48 PM Alvaro Herrera <[email protected]> wrote: > > On 2022-Mar-22, Amit Kapila wrote: > > > Add ALTER SUBSCRIPTION ... SKIP. > > There are two messages here that seem oddly worded. > > msgid "start skipping logical replication transaction finished at %X/%X" > msgid "done skipping logical replication transaction finished at %X/%X" > > Two complaints here. First, the phrases "start / finished" and "done / > finished" look very strange. It took me a while to realize that > "finished" refers to the LSN, not to the skipping operation. Do we ever > talk about a transaction "finished at XYZ" as opposed to a transaction > whose LSN is XYZ? (This became particularly strange when I realized > that the LSN might come from a PREPARE.) > The reason to add "finished at ..." was to be explicit about whether it is a starting LSN or an end LSN of a transaction. We do have such differentiation in ReorderBufferTXN (first_lsn ... end_lsn). > Second, "logical replication transaction". Is it not a regular > transaction that we happen to be processing via logical replication? > > I think they should say something like > > "logical replication starts skipping transaction with LSN %X/%X" > "logical replication completed skipping transaction with LSN %X/%X" > This looks better to me. If you find the above argument to differentiate between the start and end LSN convincing then we can think of replacing "with" in the above messages with "finished at". I see your point related to using "finished at" for PREPARE may not be a good idea but I don't have better ideas for the same. -- With Regards, Amit Kapila. ^ permalink raw reply [nested|flat] 30+ messages in thread
* Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP. @ 2022-09-06 14:10 Masahiko Sawada <[email protected]> parent: Amit Kapila <[email protected]> 0 siblings, 1 reply; 30+ messages in thread From: Masahiko Sawada @ 2022-09-06 14:10 UTC (permalink / raw) To: Amit Kapila <[email protected]>; +Cc: Alvaro Herrera <[email protected]>; Amit Kapila <[email protected]>; [email protected] On Sun, Sep 4, 2022 at 8:39 PM Amit Kapila <[email protected]> wrote: > > On Sun, Sep 4, 2022 at 1:48 PM Alvaro Herrera <[email protected]> wrote: > > > > On 2022-Mar-22, Amit Kapila wrote: > > > > > Add ALTER SUBSCRIPTION ... SKIP. > > > > There are two messages here that seem oddly worded. > > > > msgid "start skipping logical replication transaction finished at %X/%X" > > msgid "done skipping logical replication transaction finished at %X/%X" > > > > Two complaints here. First, the phrases "start / finished" and "done / > > finished" look very strange. It took me a while to realize that > > "finished" refers to the LSN, not to the skipping operation. Do we ever > > talk about a transaction "finished at XYZ" as opposed to a transaction > > whose LSN is XYZ? (This became particularly strange when I realized > > that the LSN might come from a PREPARE.) > > > > The reason to add "finished at ..." was to be explicit about whether > it is a starting LSN or an end LSN of a transaction. We do have such > differentiation in ReorderBufferTXN (first_lsn ... end_lsn). > > > Second, "logical replication transaction". Is it not a regular > > transaction that we happen to be processing via logical replication? > > > > I think they should say something like > > > > "logical replication starts skipping transaction with LSN %X/%X" > > "logical replication completed skipping transaction with LSN %X/%X" > > > > This looks better to me. +1 > If you find the above argument to > differentiate between the start and end LSN convincing then we can > think of replacing "with" in the above messages with "finished at". I > see your point related to using "finished at" for PREPARE may not be a > good idea but I don't have better ideas for the same. Given that the user normally doesn't need to be aware of the difference between start LSN and end LSN in the context of using this feature, I think we can use "with LSN %X/%X". Regards, -- Masahiko Sawada ^ permalink raw reply [nested|flat] 30+ messages in thread
* Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP. @ 2022-09-07 03:46 Amit Kapila <[email protected]> parent: Masahiko Sawada <[email protected]> 0 siblings, 0 replies; 30+ messages in thread From: Amit Kapila @ 2022-09-07 03:46 UTC (permalink / raw) To: Masahiko Sawada <[email protected]>; +Cc: Alvaro Herrera <[email protected]>; Amit Kapila <[email protected]>; [email protected] On Tue, Sep 6, 2022 at 7:40 PM Masahiko Sawada <[email protected]> wrote: > > > > I think they should say something like > > > > > > "logical replication starts skipping transaction with LSN %X/%X" > > > "logical replication completed skipping transaction with LSN %X/%X" > > > > > > > This looks better to me. > > +1 > > > If you find the above argument to > > differentiate between the start and end LSN convincing then we can > > think of replacing "with" in the above messages with "finished at". I > > see your point related to using "finished at" for PREPARE may not be a > > good idea but I don't have better ideas for the same. > > Given that the user normally doesn't need to be aware of the > difference between start LSN and end LSN in the context of using this > feature, I think we can use "with LSN %X/%X". > Fair enough. Alvaro, would you like to push your proposed change? Otherwise, I am happy to take care of this. -- With Regards, Amit Kapila. ^ permalink raw reply [nested|flat] 30+ messages in thread
end of thread, other threads:[~2022-09-07 03:46 UTC | newest] Thread overview: 30+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/21] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2021-01-24 02:33 [PATCH 14/18] doc review: logical decode in prepare Justin Pryzby <[email protected]> 2022-03-22 01:56 pgsql: Add ALTER SUBSCRIPTION ... SKIP. Amit Kapila <[email protected]> 2022-03-22 23:59 ` Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP. Andres Freund <[email protected]> 2022-03-23 01:56 ` Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP. Amit Kapila <[email protected]> 2022-09-04 08:18 ` Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP. Alvaro Herrera <[email protected]> 2022-09-04 11:38 ` Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP. Amit Kapila <[email protected]> 2022-09-06 14:10 ` Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP. Masahiko Sawada <[email protected]> 2022-09-07 03:46 ` Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP. Amit Kapila <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox