public inbox for [email protected]
help / color / mirror / Atom feed[PATCH v1] Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version()
5+ messages / 2 participants
[nested] [flat]
* [PATCH v1] Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version()
@ 2026-02-27 03:27 Bertrand Drouvot <[email protected]>
0 siblings, 0 replies; 5+ messages in thread
From: Bertrand Drouvot @ 2026-02-27 03:27 UTC (permalink / raw)
Standard practice in PostgreSQL is to use "foo(void)" instead of "foo()", as the
latter looks like an "old-style" function declaration. 9b05e2ec08a did fix
all the ones reported by -Wstrict-prototypes.
af2d4ca191a4 introduced a new one, this commit fixes it.
Author: Bertrand Drouvot <[email protected]>
Reviewed-by:
Discussion: https://postgr.es/m/
---
src/backend/utils/adt/pg_locale.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
100.0% src/backend/utils/adt/
diff --git a/src/backend/utils/adt/pg_locale.c b/src/backend/utils/adt/pg_locale.c
index ac324ecaad2..6c5c1019e1e 100644
--- a/src/backend/utils/adt/pg_locale.c
+++ b/src/backend/utils/adt/pg_locale.c
@@ -1650,7 +1650,7 @@ pg_towlower(pg_wchar wc, pg_locale_t locale)
/* version of Unicode used by ICU */
const char *
-pg_icu_unicode_version()
+pg_icu_unicode_version(void)
{
#ifdef USE_ICU
return U_UNICODE_VERSION;
--
2.34.1
--D6058a7DswGNtGTg--
^ permalink raw reply [nested|flat] 5+ messages in thread
* [PATCH v1] Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version()
@ 2026-02-27 03:27 Bertrand Drouvot <[email protected]>
0 siblings, 0 replies; 5+ messages in thread
From: Bertrand Drouvot @ 2026-02-27 03:27 UTC (permalink / raw)
Standard practice in PostgreSQL is to use "foo(void)" instead of "foo()", as the
latter looks like an "old-style" function declaration. 9b05e2ec08a did fix
all the ones reported by -Wstrict-prototypes.
af2d4ca191a4 introduced a new one, this commit fixes it.
Author: Bertrand Drouvot <[email protected]>
Reviewed-by:
Discussion: https://postgr.es/m/
---
src/backend/utils/adt/pg_locale.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
100.0% src/backend/utils/adt/
diff --git a/src/backend/utils/adt/pg_locale.c b/src/backend/utils/adt/pg_locale.c
index ac324ecaad2..6c5c1019e1e 100644
--- a/src/backend/utils/adt/pg_locale.c
+++ b/src/backend/utils/adt/pg_locale.c
@@ -1650,7 +1650,7 @@ pg_towlower(pg_wchar wc, pg_locale_t locale)
/* version of Unicode used by ICU */
const char *
-pg_icu_unicode_version()
+pg_icu_unicode_version(void)
{
#ifdef USE_ICU
return U_UNICODE_VERSION;
--
2.34.1
--D6058a7DswGNtGTg--
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version()
@ 2026-03-03 01:22 Andreas Karlsson <[email protected]>
1 sibling, 0 replies; 5+ messages in thread
From: Andreas Karlsson @ 2026-03-03 01:22 UTC (permalink / raw)
To: Joe Conway <[email protected]>; Chao Li <[email protected]>; Bertrand Drouvot <[email protected]>; +Cc: [email protected]; Jeff Davis <[email protected]>
On 2/27/26 3:58 PM, Joe Conway wrote:
> On 2/27/26 01:04, Chao Li wrote:
>> What I'm interested in is the broader policy: when reviewing
>> patches, if we encounter a foo() declaration, should we consistently
>> request a change to foo(void)? If yes, the standard should be
>> documented somewhere.
>
> Perhaps here?
>
> https://wiki.postgresql.org/wiki/Committing_checklist
Nah, I think we should just enable the warnings unless we have a good
reason not to.
Andreas
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version()
@ 2026-03-09 07:57 Bertrand Drouvot <[email protected]>
1 sibling, 1 reply; 5+ messages in thread
From: Bertrand Drouvot @ 2026-03-09 07:57 UTC (permalink / raw)
To: Peter Eisentraut <[email protected]>; +Cc: Chao Li <[email protected]>; [email protected]; Jeff Davis <[email protected]>
Hi,
On Mon, Mar 02, 2026 at 07:36:20PM +0100, Peter Eisentraut wrote:
> On 27.02.26 07:45, Bertrand Drouvot wrote:
> > Hi,
> >
> > On Fri, Feb 27, 2026 at 02:04:30PM +0800, Chao Li wrote:
> > >
> > >
> > > What I'm interested in is the broader policy: when reviewing patches,
> > > if we encounter a foo() declaration, should we consistently request a change to foo(void)?
> > > If yes, the standard should be documented somewhere.
> >
> > I think that they should be consistently fixed for the reasons mentioned in
> > [1], and that the best way to achieve this goal would be to enable -Wstrict-prototypes
> > by default ([2]).
>
> Yes, why not add -Wstrict-prototypes and perhaps -Wold-style-definition to
> the standard warnings. Then we don't have to keep chasing these manually.
Yeah, I'll look at adding those.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version()
@ 2026-03-09 16:41 Bertrand Drouvot <[email protected]>
parent: Bertrand Drouvot <[email protected]>
0 siblings, 0 replies; 5+ messages in thread
From: Bertrand Drouvot @ 2026-03-09 16:41 UTC (permalink / raw)
To: Peter Eisentraut <[email protected]>; +Cc: Chao Li <[email protected]>; [email protected]; Jeff Davis <[email protected]>
Hi,
On Mon, Mar 09, 2026 at 09:44:45AM +0100, Peter Eisentraut wrote:
> On 09.03.26 08:57, Bertrand Drouvot wrote:
> > Hi,
> >
> > On Mon, Mar 02, 2026 at 07:36:20PM +0100, Peter Eisentraut wrote:
> > > On 27.02.26 07:45, Bertrand Drouvot wrote:
> > > > Hi,
> > > >
> > > > On Fri, Feb 27, 2026 at 02:04:30PM +0800, Chao Li wrote:
> > > > >
> > > > >
> > > > > What I'm interested in is the broader policy: when reviewing patches,
> > > > > if we encounter a foo() declaration, should we consistently request a change to foo(void)?
> > > > > If yes, the standard should be documented somewhere.
> > > >
> > > > I think that they should be consistently fixed for the reasons mentioned in
> > > > [1], and that the best way to achieve this goal would be to enable -Wstrict-prototypes
> > > > by default ([2]).
> > >
> > > Yes, why not add -Wstrict-prototypes and perhaps -Wold-style-definition to
> > > the standard warnings. Then we don't have to keep chasing these manually.
> >
> > Yeah, I'll look at adding those.
>
> I played with this a little bit. A problem I found is that the generated
> configure code itself generates its test programs with 'main()', and so with
> these warnings, many of these tests will fail. So you'd need to create some
> different arrangement where you test for the warnings but only add the flags
> at the end of configure.
>
> But also, my research indicates that -Wstrict-prototypes and
> -Wold-style-definition are available in all supported gcc and clang
> versions, so maybe you could avoid this problem by not testing for them and
> just unconditionally adding them at the end.
Yeah, I did observe the same. I moved the new flags late enough in configure.ac
to avoid any error (for example, PGAC_PRINTF_ARCHETYPE which uses -Werror and
would fail to detect gnu_printf if -Wstrict-prototypes is active) leading to the
mingw_cross_warning CI task failing.
I just shared the patch in a dedicated thread [1].
[1]: https://postgr.es/m/aa73q1aT0A3/vke/@ip-10-97-1-34.eu-west-3.compute.internal
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2026-03-09 16:41 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-02-27 03:27 [PATCH v1] Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version() Bertrand Drouvot <[email protected]>
2026-02-27 03:27 [PATCH v1] Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version() Bertrand Drouvot <[email protected]>
2026-03-03 01:22 ` Andreas Karlsson <[email protected]>
2026-03-09 07:57 ` Bertrand Drouvot <[email protected]>
2026-03-09 16:41 ` Bertrand Drouvot <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox