pg.ddx.io pgsql-hackers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
From: Dag Lem <dag@nimrod.no>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Paul Ramsey <pramsey@cleverelephant.ca>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: daitch_mokotoff module
Date: Wed, 08 Feb 2023 14:23:04 +0100
Message-ID: <yge5yccqojr.fsf@sid.nimrod.no> (raw)
In-Reply-To: <c05fd131-150a-0731-ec34-3eec7bb8f8e7@enterprisedb.com>
References: <20221225130136.oyfh5jcw3xxkvq34@alvherre.pgsql>
<ygetu18tzwt.fsf@sid.nimrod.no>
<CACowWR0Lg+49Z4ncN2-U0-fUYLpAVQYupRr=0UaSLYxgrAWVHQ@mail.gmail.com>
<ygeh6wvsrc0.fsf@sid.nimrod.no>
<A2C12929-5B04-4202-95AB-A2970FB5016A@cleverelephant.ca>
<ygey1q1qm6v.fsf@sid.nimrod.no>
<ygeilgdr0q8.fsf@sid.nimrod.no>
<889A5DE5-D123-4A2A-B390-D59AE5117E28@cleverelephant.ca>
<c05fd131-150a-0731-ec34-3eec7bb8f8e7@enterprisedb.com>
Tomas Vondra <tomas.vondra@enterprisedb.com> writes:
> On 2/7/23 18:08, Paul Ramsey wrote:
>>
>>
>>> On Feb 7, 2023, at 6:47 AM, Dag Lem <dag@nimrod.no> wrote:
>>>
>>> I just went by to check the status of the patch, and I noticed that
>>> you've added yourself as reviewer earlier - great!
>>>
>>> Please tell me if there is anything I can do to help bring this across
>>> the finish line.
>>
>> Honestly, I had set it to Ready for Committer, but then I went to
>> run regression one more time and my regression blew up. I found I
>> couldn't enable the UTF tests without things failing. And I don't
>> blame you! I think my installation is probably out-of-alignment in
>> some way, but I didn't want to flip the Ready flag without having
>> run everything through to completion, so I flipped it back. Also,
>> are the UTF tests enabled by default? It wasn't clear to me that
>> they were?
>>
> The utf8 tests are enabled depending on the encoding returned by
> getdatabaseencoding(). Systems with other encodings will simply use the
> alternate .out file. And it works perfectly fine for me.
>
> IMHO it's ready for committer.
>
>
> regards
Yes, the UTF-8 tests follow the current best practice as has been
explained to me earlier. The following patch exemplifies this:
https://github.com/postgres/postgres/commit/c2e8bd27519f47ff56987b30eb34a01969b9a9e8
Best regards,
Dag Lem
view thread (69+ messages) latest in thread
Message-ID: <yge5yccqojr.fsf@sid.nimrod.no> Permalink: ../yge5yccqojr.fsf@sid.nimrod.no/ Also on: postgresql.org/message-id/yge5yccqojr.fsf@sid.nimrod.no ·
reply
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Reply to all the recipients from your mail client; the link fills in the headers below: reply via email Some clients, webmail especially, drop In-Reply-To and References from a link, and the reply then starts a new thread: use the mbox below. To: pgsql-hackers@postgresql.org Cc: dag@nimrod.no, tomas.vondra@enterprisedb.com, pramsey@cleverelephant.ca Subject: Re: daitch_mokotoff module In-Reply-To: <yge5yccqojr.fsf@sid.nimrod.no> References: <20221225130136.oyfh5jcw3xxkvq34@alvherre.pgsql> <ygetu18tzwt.fsf@sid.nimrod.no> <CACowWR0Lg+49Z4ncN2-U0-fUYLpAVQYupRr=0UaSLYxgrAWVHQ@mail.gmail.com> <ygeh6wvsrc0.fsf@sid.nimrod.no> <A2C12929-5B04-4202-95AB-A2970FB5016A@cleverelephant.ca> <ygey1q1qm6v.fsf@sid.nimrod.no> <ygeilgdr0q8.fsf@sid.nimrod.no> <889A5DE5-D123-4A2A-B390-D59AE5117E28@cleverelephant.ca> <c05fd131-150a-0731-ec34-3eec7bb8f8e7@enterprisedb.com> <yge5yccqojr.fsf@sid.nimrod.no> * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox