pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dag Lem <dag@nimrod.no>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Paul Ramsey <pramsey@cleverelephant.ca>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: daitch_mokotoff module
Date: Fri, 14 Apr 2023 13:57:15 -0400
Message-ID: <1546512.1681495035@sss.pgh.pa.us> (raw)
In-Reply-To: <9a774d09-bded-5039-0eec-2515c72215e4@dunslane.net>
References: <20230208090954.ngbokgukzx7ooj3m@alvherre.pgsql>
	<yge1qn0qldz.fsf@sid.nimrod.no>
	<53185f47-ed08-12ef-83d1-0cd26d49a209@enterprisedb.com>
	<ygesfffp4qj.fsf@sid.nimrod.no>
	<20230211025830.twigy3l65bc27cyw@awork3.anarazel.de>
	<ygeilg4pbjq.fsf@sid.nimrod.no>
	<ygeedp1gl1i.fsf@sid.nimrod.no>
	<037c6b65-019e-7e4b-4fd0-77973ea75a9f@enterprisedb.com>
	<3135273.1680893728@sss.pgh.pa.us>
	<3271512.1680916423@sss.pgh.pa.us>
	<3278776.1680918752@sss.pgh.pa.us>
	<d7fdb2fe-e0b0-ce35-827d-41cdfab655ef@dunslane.net>
	<3287943.1680922997@sss.pgh.pa.us>
	<3298809.1680924332@sss.pgh.pa.us>
	<9a774d09-bded-5039-0eec-2515c72215e4@dunslane.net>

Buildfarm member hamerkop has a niggle about this patch:

c:\\build-farm-local\\buildroot\\head\\pgsql.build\\contrib\\fuzzystrmatch\\daitch_mokotoff.c : warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the file in Unicode format to prevent data loss

It's complaining about the comment in

static const char iso8859_1_to_ascii_upper[] =
/*
"`abcdefghijklmnopqrstuvwxyz{|}~                                  ¡¢£¤¥¦§¨©ª«¬ ®¯°±²³´µ¶·¸¹º»¼½¾¿ÀÁÂÃÄÅÆÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖרÙÚÛÜÝÞßàáâãäåæçèéêëìíîïðñòóôõö÷øùúûüýþÿ"
*/
"`ABCDEFGHIJKLMNOPQRSTUVWXYZ{|}~                                  !                             ?AAAAAAECEEEEIIIIDNOOOOO*OUUUUYDSAAAAAAECEEEEIIIIDNOOOOO/OUUUUYDY";

There are some other comments with non-ASCII characters elsewhere in the
file, but I think it's mainly just the weird symbols here that might fail
to translate to encodings that are not based on ISO 8859-1.

I think we need to get rid of this warning: it's far from obvious that
it's a non-issue, and because the compiler is not at all specific about
where the issue is, people could waste a lot of time figuring that out.
In fact, it might *not* be a non-issue, if it prevents the source tree
as a whole from being processed by some tool or other.

So I propose to replace those symbols with "... random symbols ..." or
the like and see if the warning goes away.  If not, we might have to
resort to something more drastic like removing this comment altogether.
We do have non-ASCII text in comments and test cases elsewhere in the
tree, and have not had a lot of trouble with that, so I'm hoping the
letters can stay because they are useful to compare to the constant.

			regards, tom lane





view thread (69+ messages)

Message-ID: <1546512.1681495035@sss.pgh.pa.us>
Permalink:  ../1546512.1681495035@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1546512.1681495035@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, dag@nimrod.no, andrew@dunslane.net, tomas.vondra@enterprisedb.com, andres@anarazel.de, alvherre@alvh.no-ip.org, pramsey@cleverelephant.ca
  Subject: Re: daitch_mokotoff module
  In-Reply-To: <1546512.1681495035@sss.pgh.pa.us>
  References: <20230208090954.ngbokgukzx7ooj3m@alvherre.pgsql> <yge1qn0qldz.fsf@sid.nimrod.no> <53185f47-ed08-12ef-83d1-0cd26d49a209@enterprisedb.com> <ygesfffp4qj.fsf@sid.nimrod.no> <20230211025830.twigy3l65bc27cyw@awork3.anarazel.de> <ygeilg4pbjq.fsf@sid.nimrod.no> <ygeedp1gl1i.fsf@sid.nimrod.no> <037c6b65-019e-7e4b-4fd0-77973ea75a9f@enterprisedb.com> <3135273.1680893728@sss.pgh.pa.us> <3271512.1680916423@sss.pgh.pa.us> <3278776.1680918752@sss.pgh.pa.us> <d7fdb2fe-e0b0-ce35-827d-41cdfab655ef@dunslane.net> <3287943.1680922997@sss.pgh.pa.us> <3298809.1680924332@sss.pgh.pa.us> <9a774d09-bded-5039-0eec-2515c72215e4@dunslane.net> <1546512.1681495035@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox