pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Dag Lem <dag@nimrod.no>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Paul Ramsey <pramsey@cleverelephant.ca>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: daitch_mokotoff module
Date: Thu, 09 Feb 2023 10:28:36 +0100
Message-ID: <ygesfffp4qj.fsf@sid.nimrod.no> (raw)
In-Reply-To: <53185f47-ed08-12ef-83d1-0cd26d49a209@enterprisedb.com>
References: <20230208090954.ngbokgukzx7ooj3m@alvherre.pgsql>
	<yge1qn0qldz.fsf@sid.nimrod.no>
	<53185f47-ed08-12ef-83d1-0cd26d49a209@enterprisedb.com>

Tomas Vondra <tomas.vondra@enterprisedb.com> writes:

> On 2/8/23 15:31, Dag Lem wrote:
>> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
>> 
>>> On 2023-Jan-17, Dag Lem wrote:
>>>
>>>> + * Daitch-Mokotoff Soundex
>>>> + *
>>>> + * Copyright (c) 2021 Finance Norway
>>>> + * Author: Dag Lem <dag@nimrod.no>
>>>
>>> Hmm, I don't think we accept copyright lines that aren't "PostgreSQL
>>> Global Development Group".  Is it okay to use that, and update the year
>>> to 2023?  (Note that answering "no" very likely means your patch is not
>>> candidate for inclusion.)  Also, we tend not to have "Author:" lines.
>>>
>> 
>> You'll have to forgive me for not knowing about this rule:
>> 
>>   grep -ER "Copyright.*[0-9]{4}" contrib/ | grep -v PostgreSQL
>> 
>> In any case, I have checked with the copyright owner, and it would be OK
>> to assign the copyright to "PostgreSQL Global Development Group".
>> 
>
> I'm not entirely sure what's the rule either, and I'm a committer. My
> guess is these cases are either old and/or adding a code that already
> existed elsewhere (like some of the double metaphone, for example), or
> maybe both. But I'd bet we'd prefer not adding more ...
>
>> To avoid going back and forth with patches, how do you propose that the
>> sponsor and the author of the contributed module should be credited?
>> Woule something like this be acceptable?
>> 
>
> We generally credit contributors in two ways - by mentioning them in the
> commit message, and by listing them in the release notes (for individual
> features).
>

I'll ask again, would the proposed credits be acceptable? In this case,
the code already existed elsewhere (as in your example for double
metaphone) as a separate extension. The copyright owner is OK with
copyright assignment, however I find it quite unreasonable that proper
credits should not be given. Neither commit messages nor release notes
follow the contributed module, which is in its entirety contributed by
an external entity.

I'll also point out that in addition to credits in code all over the
place, PostgreSQL has much more prominent credits in the documentation:

  grep -ER "Author" doc/ | grep -v PostgreSQL

"Author" is even documented as a top level section in the Reference
Pages as "Author (only used in the contrib section)", see

  https://www.postgresql.org/docs/15/docguide-style.html#id-1.11.11.8.2

If there really exists some new rule which says that for new
contributions under contrib/, credits should not be allowed in any way
in either code or documentation (IANAL, but AFAIU this would be in
conflict with laws on author's moral rights in several countries), then
one would reasonably expect that you'd be upfront about this, both in
documentation, and also as the very first thing when a contribution is
first proposed for inclusion.

Best regards

Dag Lem





view thread (69+ messages)  latest in thread

Message-ID: <ygesfffp4qj.fsf@sid.nimrod.no>
Permalink:  ../ygesfffp4qj.fsf@sid.nimrod.no/
Also on:    postgresql.org/message-id/ygesfffp4qj.fsf@sid.nimrod.no

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: dag@nimrod.no, tomas.vondra@enterprisedb.com, alvherre@alvh.no-ip.org, pramsey@cleverelephant.ca
  Subject: Re: daitch_mokotoff module
  In-Reply-To: <ygesfffp4qj.fsf@sid.nimrod.no>
  References: <20230208090954.ngbokgukzx7ooj3m@alvherre.pgsql> <yge1qn0qldz.fsf@sid.nimrod.no> <53185f47-ed08-12ef-83d1-0cd26d49a209@enterprisedb.com> <ygesfffp4qj.fsf@sid.nimrod.no>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox