From: Andrew C.R. Martin <a.c.r.martin@reading.ac.uk>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: interfaces@postgresql.org
Cc: docs@postgresql.org
Cc: hackers@postgresql.org
Subject: Re: Re: [HACKERS] Re: Bugs: Programming Language Functions
Date: Thu, 13 Apr 2000 10:31:58 +0100
Message-ID: <00041310400304.29884@sapc13.rdg.ac.uk> (raw)
References: <00041308564200.29884@sapc13.rdg.ac.uk>
On Thu, 13 Apr 2000, Andrew C.R. Martin wrote:
> On Tue, 11 Apr 2000, Tom Lane wrote:
> > "Andrew C.R. Martin" <a.c.r.martin@reading.ac.uk> writes:
> > >> Hm. I'm not too clear on why that would need to worry about either
> > >> TupleTableSlot or GetAttributeByName ... shouldn't it be a simple
> > >> function consuming a text Datum and producing another?
> >
> > > Errrmmm, just following the instructions in the docs:
> >
> > > Programmer's Manual, Chapter 4. Extensing SQL: Functins (page
> > > x414.htm), under the C examples.
> >
Eeek! Forget my idea of #define'ing TupleTableSlot as TUPLE for backwards
compatibility. I've just realised that GetAttributeByName() now takes
a TupleTableSlot *pointer* whereas it used to take a TUPLE structure (not a
pointer).
Personally whenever I make a code change like this I try to create a new
function with the altered parameters and then make a wrapper with the old name
and calling style for backwards compatibility :-)
It seems that the .../src/tutorial/func.* examples have been updated correctly
The create_function man page however has not been updated (it even refers to
libpq-fe.h still as well as to TUPLE) and the main printable manual needs to be
updated.
Best wishes,
Andrew
--
Dr. Andrew C.R. Martin EMail: a.c.r.martin@reading.ac.uk (work)
Lecturer in Bioinformatics andrew@stagleys.demon.co.uk (home)
University of Reading
Tel.: +44 (0)118 987 5123x7022 Fax: +44 (0)118 931 0180
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-interfaces@postgresql.org
Cc: a.c.r.martin@reading.ac.uk, tgl@sss.pgh.pa.us, interfaces@postgresql.org, docs@postgresql.org, hackers@postgresql.org
Subject: Re: Re: [HACKERS] Re: Bugs: Programming Language Functions
In-Reply-To: <00041310400304.29884@sapc13.rdg.ac.uk>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox