From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <pgman@candle.pha.pa.us>
Cc: Gerhard Häring <lists@ghaering.de>
Cc: pgsql-interfaces@postgresql.org
Subject: Re: I want to send comments to the backend!
Date: Fri, 21 Mar 2003 00:41:34 -0500
Message-ID: <10177.1048225294@sss.pgh.pa.us> (raw)
In-Reply-To: <200303210516.h2L5Gq104398@candle.pha.pa.us>
References: <200303210516.h2L5Gq104398@candle.pha.pa.us>
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> OK, this patch fixes the comment passing bug. I remove the strspn() and
> added a boolean to test if any parsetree had been generated --- if not,
> I call NullCommand().
Seems like the hard way. I had in mind a quick
if (parsetree_list == NIL)
{
NullCommand(dest);
return;
}
before entering the main loop. It'd take a small amount of reordering
of the existing code to make this happen without adding any more code
than that, but it looked doable.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-interfaces@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgman@candle.pha.pa.us, lists@ghaering.de
Subject: Re: I want to send comments to the backend!
In-Reply-To: <10177.1048225294@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox