From: Pavel Golub <pavel@microolap.com>
To: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
To: pgsql-interfaces@postgresql.org
Subject: PQdeleteTuple function in libpq
Date: Wed, 1 Jun 2011 18:43:10 +0300
Message-ID: <147534417.20110601184310@gf.microolap.com> (raw)
Hello.
I'm some kind of PQdeleteTuple function will be very usefull in libpq.
Because right now after deleting some record I need refetch result
set, or mark tuple as deleted and this is headache for me.
So I checked fe-exec.c sources and wrote this:
int PQdeleteTuple(PGresult *src, int tup_num)
{
if (!src)
return NULL;
int i,
field;
/* Invalid tup_num, must be < ntups */
if (tup_num < 0 || tup_num >= src->ntups)
return FALSE;
free(src->tuples[tup_num]);
for (i = tup_num; i < src->ntups - 1; i++)
{
src->tuples[i] = src->tuples[i + 1];
}
src->ntups--;
return TRUE;
}
But I'm pretty sure, that "free(src->tuples[tup_num])" is bullshit!
Because memory is allocated by pqResultAlloc, which in turn plays with
memory blocks and so on...
Can anyone help me in this?
PS I'm not a C guru, so don't please kick me hard. :)
Thanks.
--
With best wishes,
Pavel mailto:pavel@gf.microolap.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-interfaces@postgresql.org
Cc: pavel@microolap.com, pgsql-hackers@postgresql.org
Subject: Re: PQdeleteTuple function in libpq
In-Reply-To: <147534417.20110601184310@gf.microolap.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox