agora inbox for pgsql-interfaces@postgresql.org
help / color / mirror / Atom feedFrom: Pavel Golub <pavel@microolap.com>
To: Andrew Chernow <ac@esilo.com>
Cc: Alvaro Herrera <alvherre@commandprompt.com>
Cc: Pavel Golub <pavel@microolap.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Cc: pgsql-interfaces <pgsql-interfaces@postgresql.org>
Subject: Re: [HACKERS] PQdeleteTuple function in libpq
Date: Fri, 3 Jun 2011 08:54:13 +0300
Message-ID: <163769889.20110603085413@gf.microolap.com> (raw)
In-Reply-To: <4DE7B660.8040704@esilo.com>
References: <147534417.20110601184310@gf.microolap.com>
<4DE6A5B7.2070700@esilo.com>
<707574086.20110602112826@gf.microolap.com>
<4DE79A58.4010608@esilo.com>
<1307026778-sup-415@alvh.no-ip.org>
<4DE7B660.8040704@esilo.com>
Hello, Andrew.
You wrote:
AC> On 6/2/2011 11:02 AM, Alvaro Herrera wrote:
>> Excerpts from Andrew Chernow's message of jue jun 02 10:12:40 -0400 2011:
>>
>>>> Andrew, why we have PQmakeEmptyPGresult, PQcopyResult,
>>>> PQsetResultAttrs, PQsetvalue and PQresultAlloc in this case? Of course
>>>> there's no big deal with their absence but let's be consistent.
>>>
>>> I'm not entirely sure what you are trying to do, but can't you use
>>> PQmakeEmptyPGresult, PQsetResultAttrs and PQsetvalue to construct a
>>> result that excludes the tuples you don't want followed by a
>>> PQclear(initial_result)?
>>
>> Seems pretty wasteful if you want to delete a single tuple from a large
>> result. I think if you desired to compact the result to free some
>> memory after deleting a large fraction of the tuples in the result it
>> could be useful to do that, otherwise just live with the unused holes in
>> the storage area as suggested by Pavel.
>>
AC> Another solution is to manually cursor through the set (like grab 1000
AC> tuples at a time) and copy the set to your own structure. That way, the
AC> temporary double memory to perform the copy is not as big of a hit. By
AC> using your own structure, you can organize the memory in a fashion that
AC> is optimized for your requirement.
I agree that there are a lot of possible solutions. But let me compare
my function with official PQsetValue:
1. Both allow changing data in PGresult
2. Both allow changing tuples number
3. Both leave old data untouchable to be eliminated by PQClear
4. PQsetValue allocates more memory during work, mine not (it even may
allow deleted tuple to be reused with a little fix)
So why shouldn't we have both of them to make life easier?
--
With best wishes,
Pavel mailto:pavel@gf.microolap.com
view thread (17+ messages)
Message-ID: <163769889.20110603085413@gf.microolap.com>
Permalink: ../163769889.20110603085413@gf.microolap.com/
Also on: postgresql.org/message-id/163769889.20110603085413@gf.microolap.com
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-interfaces@postgresql.org
Cc: pavel@microolap.com, ac@esilo.com, alvherre@commandprompt.com, pgsql-hackers@postgresql.org
Subject: Re: [HACKERS] PQdeleteTuple function in libpq
In-Reply-To: <163769889.20110603085413@gf.microolap.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox