agora inbox for pgsql-interfaces@postgresql.org  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Christian Ullrich <chris@chrullrich.de>
Cc: pgsql-interfaces@postgresql.org
Subject: Re: libpq++ on Windows
Date: Mon, 02 Jul 2001 00:21:45 -0400
Message-ID: <1598.994047705@sss.pgh.pa.us> (raw)
In-Reply-To: <20010702002319.A1387@christian.chrullrich.de>
References: <20010701174549.A976@christian.chrullrich.de>
	<Pine.LNX.4.30.0107012027420.1674-100000@peter.localdomain>
	<20010702002319.A1387@christian.chrullrich.de>

Christian Ullrich <chris@chrullrich.de> writes:
> * Peter Eisentraut wrote on Sunday, 2001-07-01:
>> Why not put the addition to config.h.in into config.h.win32?  When doing a
>> native Win32 build config.h.in isn't used anyway.

> Because the '#define DLLAPI' in config.h.in -- from which the 
> config.h for Unix and Cygwin/Win32 builds is generated -- is 
> necessary to make the compiler happy about the modifications
> to the class declarations.

config.h.in is absolutely NOT the right place for platform-specific
defines.

I'd put this in the same category as DLLIMPORT, which is in c.h
(and just as ugly an example of Microsoft cultural imperialism,
but I suppose there's no point in arguing about it).

			regards, tom lane



view thread (26+ messages)  latest in thread

Message-ID: <1598.994047705@sss.pgh.pa.us>
Permalink:  ../1598.994047705@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1598.994047705@sss.pgh.pa.us

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-interfaces@postgresql.org
  Cc: tgl@sss.pgh.pa.us, chris@chrullrich.de
  Subject: Re: libpq++ on Windows
  In-Reply-To: <1598.994047705@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox