From: Tom Lane <tgl@sss.pgh.pa.us>
To: Vlad <marchenko@gmail.com>
Cc: Brandon Metcalf <bmetcalf@nortel.com>
Cc: dbdpg-general@gborg.postgresql.org
Cc: pgsql-interfaces@postgresql.org
Subject: Re: [Dbdpg-general] benchmarking old Pg and DBD::Pg
Date: Fri, 08 Apr 2005 16:41:37 -0400
Message-ID: <16762.1112992897@sss.pgh.pa.us> (raw)
In-Reply-To: <cd70c68105040813249ec7813@mail.gmail.com>
References: <Pine.LNX.4.58L.0504081127400.18466@cash.rhiamet.com>
<cd70c6810504081112694ba268@mail.gmail.com>
<Pine.LNX.4.58L.0504081316270.18466@cash.rhiamet.com>
<cd70c68105040811403321e846@mail.gmail.com>
<16221.1112987509@sss.pgh.pa.us>
<cd70c681050408122241d026c5@mail.gmail.com>
<Pine.LNX.4.58L.0504081513100.18466@cash.rhiamet.com>
<cd70c68105040813249ec7813@mail.gmail.com>
Vlad <marchenko@gmail.com> writes:
> diff -ru DBD-Pg-1.41/types.c DBD-Pg-1.41-patched/types.c
> --- DBD-Pg-1.41/types.c Fri Apr 8 16:06:23 2005
> +++ DBD-Pg-1.41-patched/types.c Fri Apr 8 15:46:37 2005
> @@ -55,7 +55,7 @@
> {ABSTIMEOID, "abstime", DBDPG_TRUE, null_quote, null_dequote, {0}},
> {RELTIMEOID, "reltime", DBDPG_TRUE, null_quote, null_dequote, {0}},
> {TINTERVALOID, "tinterval", DBDPG_TRUE, null_quote, null_dequote, {0}},
> - {UNKNOWNOID, "unknown", DBDPG_FALSE, null_quote, null_dequote, {0}},
> + {UNKNOWNOID, "unknown", DBDPG_FALSE, quote_varchar, null_dequote, {0}},
> {CIRCLEOID, "circle", DBDPG_FALSE, null_quote, null_dequote, {0}},
> {CASHOID, "money", DBDPG_TRUE, null_quote, null_dequote, {0}},
> {MACADDROID, "MAC address", DBDPG_TRUE,
> quote_varchar,dequote_varchar, {0}},
Hmm ... if those columns mean what it looks like they mean, quite a few
of the other entries seem wrong too. All of the types visible in that
fragment ought to be quoted when used as SQL literals.
Also, if the MACADDROID entry is any precedent, shouldn't you be
changing the dequote field too?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-interfaces@postgresql.org
Cc: tgl@sss.pgh.pa.us, marchenko@gmail.com, bmetcalf@nortel.com, dbdpg-general@gborg.postgresql.org
Subject: Re: [Dbdpg-general] benchmarking old Pg and DBD::Pg
In-Reply-To: <16762.1112992897@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox