pg.ddx.io  pgsql-interfaces@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <pgman@candle.pha.pa.us>
Cc: Peter Eisentraut <peter_e@gmx.net>
Cc: Dan Lyke <danlyke@flutterby.com>
Cc: pgsql-interfaces@postgresql.org
Subject: Re: Double newline bug with DBD::Pg: Where best to fix?
Date: Wed, 28 Feb 2001 14:02:13 -0500
Message-ID: <19053.983386933@sss.pgh.pa.us> (raw)
In-Reply-To: <200102281806.NAA05912@candle.pha.pa.us>
References: <200102281806.NAA05912@candle.pha.pa.us>

Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Peter, I have thought about this some more.   Seems we either add the
> 'quote' check, or remove the optimizations completely.  Because we have
> to change it one way or the other for 7.1, it seems we should just
> remove the tests totally.

It's kind of handy that, for example, you can hit return a few times
without causing psql to think that something's been put into the query
buffer.  I'm worried that removing this code entirely might lead to
problems like failure to recognize backslash commands preceded by
whitespace.

Peter's patch looks like the most conservative fix to me ...

			regards, tom lane



view thread (10+ messages)

Message-ID: <19053.983386933@sss.pgh.pa.us>
Permalink:  ../19053.983386933@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/19053.983386933@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-interfaces@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgman@candle.pha.pa.us, peter_e@gmx.net, danlyke@flutterby.com
  Subject: Re: Double newline bug with DBD::Pg: Where best to fix?
  In-Reply-To: <19053.983386933@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox