pg.ddx.io pgsql-interfaces@postgresql.org mailing list archive help / color / mirror / Atom feed From: Bruce Momjian <pgman@candle.pha.pa.us>
To: Barry Lind <barry@xythos.com>
Cc: pgsql-patches@postgresql.org
Cc: pgsql-interfaces@postgresql.org
Subject: Re: Two minor fixes to reduce resource usage in JDBC drivers
Date: Thu, 28 Dec 2000 18:56:58 -0500 (EST)
Message-ID: <200012282356.SAA21967@candle.pha.pa.us> (raw )
In-Reply-To: <3A49032E.BBD063FF@xythos.com >
Thanks. Applied.
---------------------------------------------------------------------------
inline patch 1: ./org/postgresql/jdbc1/PreparedStatement.java, ./org/postgresql/jdbc1/ResultSet.java, ./org/postgresql/jdbc2/PreparedStatement.java and 1 more (+16/-14 lines) download inline-1.patch *** ./org/postgresql/jdbc1/PreparedStatement.java.orig Tue Dec 26 11:50:03 2000
--- ./org/postgresql/jdbc1/PreparedStatement.java Tue Dec 26 11:15:52 2000
***************
*** 164,170 ****
*/
public void setByte(int parameterIndex, byte x) throws SQLException
{
! set(parameterIndex, (new Integer(x)).toString());
}
/**
--- 164,170 ----
*/
public void setByte(int parameterIndex, byte x) throws SQLException
{
! set(parameterIndex, Integer.toString(x));
}
/**
***************
*** 177,183 ****
*/
public void setShort(int parameterIndex, short x) throws SQLException
{
! set(parameterIndex, (new Integer(x)).toString());
}
/**
--- 177,183 ----
*/
public void setShort(int parameterIndex, short x) throws SQLException
{
! set(parameterIndex, Integer.toString(x));
}
/**
***************
*** 190,196 ****
*/
public void setInt(int parameterIndex, int x) throws SQLException
{
! set(parameterIndex, (new Integer(x)).toString());
}
/**
--- 190,196 ----
*/
public void setInt(int parameterIndex, int x) throws SQLException
{
! set(parameterIndex, Integer.toString(x));
}
/**
***************
*** 203,209 ****
*/
public void setLong(int parameterIndex, long x) throws SQLException
{
! set(parameterIndex, (new Long(x)).toString());
}
/**
--- 203,209 ----
*/
public void setLong(int parameterIndex, long x) throws SQLException
{
! set(parameterIndex, Long.toString(x));
}
/**
***************
*** 216,222 ****
*/
public void setFloat(int parameterIndex, float x) throws SQLException
{
! set(parameterIndex, (new Float(x)).toString());
}
/**
--- 216,222 ----
*/
public void setFloat(int parameterIndex, float x) throws SQLException
{
! set(parameterIndex, Float.toString(x));
}
/**
***************
*** 229,235 ****
*/
public void setDouble(int parameterIndex, double x) throws SQLException
{
! set(parameterIndex, (new Double(x)).toString());
}
/**
--- 229,235 ----
*/
public void setDouble(int parameterIndex, double x) throws SQLException
{
! set(parameterIndex, Double.toString(x));
}
/**
*** ./org/postgresql/jdbc1/ResultSet.java.orig Tue Dec 26 11:50:03 2000
--- ./org/postgresql/jdbc1/ResultSet.java Tue Dec 26 11:22:41 2000
***************
*** 127,133 ****
*/
public void close() throws SQLException
{
! // No-op
}
/**
--- 127,134 ----
*/
public void close() throws SQLException
{
! //release resources held (memory for tuples)
! rows.setSize(0);
}
/**
*** ./org/postgresql/jdbc2/PreparedStatement.java.orig Tue Dec 26 11:50:04 2000
--- ./org/postgresql/jdbc2/PreparedStatement.java Tue Dec 26 11:14:33 2000
***************
*** 164,170 ****
*/
public void setByte(int parameterIndex, byte x) throws SQLException
{
! set(parameterIndex, (new Integer(x)).toString());
}
/**
--- 164,170 ----
*/
public void setByte(int parameterIndex, byte x) throws SQLException
{
! set(parameterIndex, Integer.toString(x));
}
/**
***************
*** 177,183 ****
*/
public void setShort(int parameterIndex, short x) throws SQLException
{
! set(parameterIndex, (new Integer(x)).toString());
}
/**
--- 177,183 ----
*/
public void setShort(int parameterIndex, short x) throws SQLException
{
! set(parameterIndex, Integer.toString(x));
}
/**
***************
*** 190,196 ****
*/
public void setInt(int parameterIndex, int x) throws SQLException
{
! set(parameterIndex, (new Integer(x)).toString());
}
/**
--- 190,196 ----
*/
public void setInt(int parameterIndex, int x) throws SQLException
{
! set(parameterIndex, Integer.toString(x));
}
/**
***************
*** 203,209 ****
*/
public void setLong(int parameterIndex, long x) throws SQLException
{
! set(parameterIndex, (new Long(x)).toString());
}
/**
--- 203,209 ----
*/
public void setLong(int parameterIndex, long x) throws SQLException
{
! set(parameterIndex, Long.toString(x));
}
/**
***************
*** 216,222 ****
*/
public void setFloat(int parameterIndex, float x) throws SQLException
{
! set(parameterIndex, (new Float(x)).toString());
}
/**
--- 216,222 ----
*/
public void setFloat(int parameterIndex, float x) throws SQLException
{
! set(parameterIndex, Float.toString(x));
}
/**
***************
*** 229,235 ****
*/
public void setDouble(int parameterIndex, double x) throws SQLException
{
! set(parameterIndex, (new Double(x)).toString());
}
/**
--- 229,235 ----
*/
public void setDouble(int parameterIndex, double x) throws SQLException
{
! set(parameterIndex, Double.toString(x));
}
/**
*** ./org/postgresql/jdbc2/ResultSet.java.orig Tue Dec 26 11:50:04 2000
--- ./org/postgresql/jdbc2/ResultSet.java Tue Dec 26 11:22:46 2000
***************
*** 128,134 ****
*/
public void close() throws SQLException
{
! // No-op
}
/**
--- 128,135 ----
*/
public void close() throws SQLException
{
! //release resources held (memory for tuples)
! rows.setSize(0);
}
/**
http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
view thread (2+ messages)
Message-ID: <200012282356.SAA21967@candle.pha.pa.us>
Permalink: ../200012282356.SAA21967@candle.pha.pa.us/
Also on: postgresql.org/message-id/200012282356.SAA21967@candle.pha.pa.us
copy link · copy postgr.es · copy git am
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-interfaces@postgresql.org
Cc: pgman@candle.pha.pa.us, barry@xythos.com, pgsql-patches@postgresql.org
Subject: Re: Two minor fixes to reduce resource usage in JDBC drivers
In-Reply-To: <200012282356.SAA21967@candle.pha.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox