pg.ddx.io  pgsql-interfaces@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Bruce Momjian <pgman@candle.pha.pa.us>
To: Hiroshi Inoue <Inoue@tpf.co.jp>
Cc: Keith Millard <Kmillard@pumatech.com>
Cc: PostgreSQL odbc list <pgsql-odbc@postgresql.org>
Subject: Re: Re: [INTERFACES] Postgres odbc driver bug
Date: Tue, 8 May 2001 21:53:31 -0400 (EDT)
Message-ID: <200105090153.f491rWd17938@candle.pha.pa.us> (raw)
In-Reply-To: <3AF89956.47FEDBF5@tpf.co.jp>

> Bruce Momjian wrote:
> > 
> > OK, I have created a context diff of your changes, which is
> attached.
> > Can someone comment on this?  The patch appears to deal with
> > STMT_PREMATURE differently than our current code.
> > 
> > In fact, it seems to disable this code:
> > 
> >     /*
> >      * If the statement is premature, it means we already executed it from
> >      * an SQLPrepare/SQLDescribeCol type of scenario.  So just return
> >      * success.
> >      */
> >     if (stmt->prepare && stmt->status == STMT_PREMATURE)
> > 
> 
> Though this fixes the bug reported by Keith, STMT_PREMATURE
> loses its meaning and SC_pre_execute() does a non-essential
> work as a result. Possibly SQLPrepare() must be rewritten
> though I'm not sure.  

OK, I see you have applied your patch:
	
	1) [ODBC] Psqlodbc and Centura: here it is a patch
	        posted by Matteo Cavalleli
	2) [ODBC] pgsqODBC binding parameters II
	        posted by Ludek Finstrle
	3) Invalid Page Fault in PSQLODBC.DLL
	        personal mail from Johann Zuschlag

I removed it from the outstanding patches page.  

And you are saying that this patch fixes a different problem.  The user
reported his problems were fixed by that patch, so I am inclined to
apply it.

Thanks.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026



view thread (14+ messages)  latest in thread

Message-ID: <200105090153.f491rWd17938@candle.pha.pa.us>
Permalink:  ../200105090153.f491rWd17938@candle.pha.pa.us/
Also on:    postgresql.org/message-id/200105090153.f491rWd17938@candle.pha.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-interfaces@postgresql.org
  Cc: pgman@candle.pha.pa.us, Inoue@tpf.co.jp, Kmillard@pumatech.com, pgsql-odbc@postgresql.org
  Subject: Re: Re: [INTERFACES] Postgres odbc driver bug
  In-Reply-To: <200105090153.f491rWd17938@candle.pha.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox