From: Bruce Momjian <pgman@candle.pha.pa.us>
To: ljb <lbayuk@mindspring.com>
Cc: pgsql-interfaces@postgresql.org
Subject: Re: libpgtcl pg_execute
Date: Thu, 11 Apr 2002 17:42:06 -0400 (EDT)
Message-ID: <200204112142.g3BLg6908782@candle.pha.pa.us> (raw)
In-Reply-To: <a5uku1$149j$1@jupiter.hub.org>
This was applied March 4. I was not sure you had been informed so I am
sending this email.
---------------------------------------------------------------------------
ljb wrote:
> tgl@sss.pgh.pa.us wrote:
>
> > Looking at the CVS logs, I see that Jan added this command; he should be
> > blamed for not having added any documentation. Feel free to contribute
> > a documentation patch ...
>
> I have documentation, but just as plain text. Unfortunately I don't have
> the tools or know-how to get it (correctly) into SGML at this time.
> What should I do?
>
> > What's wrong with the -oid code?
>
> pg_execute throws an error when you use -oid (with no error message), because
> the return value check on Tcl_SetVar is wrong. Here's the fix:
>
> *** src/interfaces/libpgtcl/pgtclCmds.c.orig Mon Dec 3 09:49:46 2001
> --- src/interfaces/libpgtcl/pgtclCmds.c Mon Feb 18 17:25:27 2002
> ***************
> *** 909,915 ****
>
> sprintf(oid_buf, "%u", PQoidValue(result));
> if (Tcl_SetVar(interp, oid_varname, oid_buf,
> ! TCL_LEAVE_ERR_MSG) != TCL_OK)
> {
> PQclear(result);
> return TCL_ERROR;
> --- 909,915 ----
>
> sprintf(oid_buf, "%u", PQoidValue(result));
> if (Tcl_SetVar(interp, oid_varname, oid_buf,
> ! TCL_LEAVE_ERR_MSG) == NULL)
> {
> PQclear(result);
> return TCL_ERROR;
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://archives.postgresql.org
>
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-interfaces@postgresql.org
Cc: pgman@candle.pha.pa.us, lbayuk@mindspring.com
Subject: Re: libpgtcl pg_execute
In-Reply-To: <200204112142.g3BLg6908782@candle.pha.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox