pg.ddx.io  pgsql-interfaces@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Bruce Momjian <pgman@candle.pha.pa.us>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: PostgreSQL Development <pgsql-hackers@postgresql.org>
Subject: Re: PQfnumber and quoted identifiers
Date: Sun, 5 Oct 2003 13:58:21 -0400 (EDT)
Message-ID: <200310051758.h95HwL212741@candle.pha.pa.us> (raw)
In-Reply-To: <Pine.LNX.4.44.0310051632370.2745-100000@peter.localdomain>

Peter Eisentraut wrote:
> There was a discussion on -interfaces that might need more consideration.
> 
> http://archives.postgresql.org/pgsql-interfaces/2003-09/msg00026.php
> 
> 
> Apparently, it has so far been an undocumented feature of libpq's function
> PGfnumber (return column number from column name) that the column name
> needs to be double-quoted if it contains upper-case letters.  That, is you
> need to write
> 
> PQfnumber(res, "\"Bar\"")
> 
> I think this is completely bizarre and pointless.  This is a C interface
> and not SQL.  Other libpq functions that accept names of SQL objects don't
> do this.  Also, PQfname and PQfnumber ought to be inverses.
> 
> Since this behavior was undocumented and no one had noticed it in the last
> 10 years, I think we can away with removing it.

I agree.  I would never expect to add quotes to a C string to preserve
case (outside SQL), and the fact that PQfname doesn't return the string
in quotes is another inconsistency.  It is sort of like case coming out
is significant, but case going in has to be quoted --- am I getting this
right?  Do we do this in other areas?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073



view thread (10+ messages)  latest in thread

Message-ID: <200310051758.h95HwL212741@candle.pha.pa.us>
Permalink:  ../200310051758.h95HwL212741@candle.pha.pa.us/
Also on:    postgresql.org/message-id/200310051758.h95HwL212741@candle.pha.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-interfaces@postgresql.org
  Cc: pgman@candle.pha.pa.us, peter_e@gmx.net, pgsql-hackers@postgresql.org
  Subject: Re: PQfnumber and quoted identifiers
  In-Reply-To: <200310051758.h95HwL212741@candle.pha.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox