From: Alvaro Herrera <alvherre@commandprompt.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Glaesemann <grzm@myrealbox.com>
Cc: pgsql-patches@postgreSQL.org
Cc: pgsql-interfaces@postgreSQL.org
Subject: Re: Proposed p.tch for error locations
Date: Mon, 13 Mar 2006 12:03:35 -0400
Message-ID: <20060313160335.GN8274@surnet.cl> (raw)
In-Reply-To: <7693.1142265427@sss.pgh.pa.us>
References: <5114.1142185055@sss.pgh.pa.us>
<C3817205-17E1-4D6C-9D92-ED6045123F92@myrealbox.com>
<7274.1142262691@sss.pgh.pa.us>
<20060313153209.GA15002@surnet.cl>
<7693.1142265427@sss.pgh.pa.us>
Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
> > This doesn't work on terminal using a variable-width font, does it?
> > Sure, you can have all the interfaces use a monospace font, but it seems
> > a weird thing to do. I think the line/character position should be
> > returned in a separate error attribute in ereport. So for example
> > pgAdmin could count characters and mark it in bold or use a different
> > color.
>
> That information is already available to pgAdmin, and has been since
> 7.4; if they are failing to exploit it that's their problem not libpq's.
Aye, that's fine. I don't really know if pgAdmin uses the info or not.
I thought the proposal to remove the "at character N" in the error
message meant that the only way to get that information would be from
the "LINE Y: ...\n[some whitespace]^" message, which would be pretty
cumbersome. But if there already is a field in the error message for
the position, then nothing is lost.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-interfaces@postgresql.org
Cc: alvherre@commandprompt.com, tgl@sss.pgh.pa.us, grzm@myrealbox.com, pgsql-patches@postgreSQL.org
Subject: Re: Proposed p.tch for error locations
In-Reply-To: <20060313160335.GN8274@surnet.cl>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox