pg.ddx.io  pgsql-interfaces@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ian Barwick <barwick@gmx.net>
Cc: dbi-dev@perl.org
Cc: pgsql-interfaces@postgresql.org
Subject: Re: Patch for DBD::Pg pg_relcheck problem
Date: Mon, 09 Dec 2002 11:03:52 -0500
Message-ID: <8159.1039449832@sss.pgh.pa.us> (raw)
In-Reply-To: <200212091631.00125.barwick@gmx.net>
References: <200212091631.00125.barwick@gmx.net>

Ian Barwick <barwick@gmx.net> writes:
> To avoid voodoo with PostgreSQL version numbers
> a check is made whether pg_relcheck exists and
> the appropriate query (either 7.3 or pre 7.3)
> executed.

I would think that looking at version number (select version())
would be a much cleaner approach.  Or do you think that direct
examination of pg_class is a version-independent operation?

This inquiry into pg_relcheck's existence is already arguably wrong
in 7.3 (since it's not taking account of which schema pg_relcheck
might be found in) and it can only go downhill in future versions.

			regards, tom lane



view thread (22+ messages)  latest in thread

Message-ID: <8159.1039449832@sss.pgh.pa.us>
Permalink:  ../8159.1039449832@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/8159.1039449832@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-interfaces@postgresql.org
  Cc: tgl@sss.pgh.pa.us, barwick@gmx.net, dbi-dev@perl.org
  Subject: Re: Patch for DBD::Pg pg_relcheck problem
  In-Reply-To: <8159.1039449832@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox