pg.ddx.io  pgsql-interfaces@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jason E. Stewart <jason@openinformatics.com>
To: Dave Rolsky <autarch@urth.org>
Cc: David Wheeler <david@wheeler.net>
Cc: pgsql-interfaces@postgresql.org
Cc: dbi-dev@perl.org
Subject: Re: ANNOUNCE: DBD::Pg 1.20
Date: 30 Nov 2002 10:47:09 -0700
Message-ID: <87k7ivt0f6.fsf@openinformatics.com> (raw)
In-Reply-To: <Pine.LNX.4.50.0211291336140.29663-100000@urth.org>
References: <84A43EBC-0235-11D7-929B-0003931A964A@wheeler.net>
	<Pine.LNX.4.50.0211291336140.29663-100000@urth.org>

"Dave Rolsky" <autarch@urth.org> writes:

> I found a bug in the ->tables method.  It includes all the system tables.
> A patch is at the bottom of the message.

Thanks Dave,

> The SQL was correct in 1.13 so I'm not sure how this happened.  There's
> also no real test of this method in the test suite, other than testing to
> make sure that calling it doesn't die.  But you need to test that it
> returns the right thing too ;)
> 
> I'd like to offer a test patch but I don't know exactly what you'd expect
> to find in the schema during testing.

t/01setup.t has the following:

  my $sql = <<SQL;
  CREATE TABLE test (
    id int,
    name text,
    val text,
    score float,
    date timestamp default 'now()'
  )
  SQL

You can expect that table to exist. Also, you could create a couple of
more tables/views and test that as well.

Cheers,
jas.

PS. Thanks for the Mason book, I'm enjoying it.



view thread (7+ messages)  latest in thread

Message-ID: <87k7ivt0f6.fsf@openinformatics.com>
Permalink:  ../87k7ivt0f6.fsf@openinformatics.com/
Also on:    postgresql.org/message-id/87k7ivt0f6.fsf@openinformatics.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-interfaces@postgresql.org
  Cc: jason@openinformatics.com, autarch@urth.org, david@wheeler.net, dbi-dev@perl.org
  Subject: Re: ANNOUNCE: DBD::Pg 1.20
  In-Reply-To: <87k7ivt0f6.fsf@openinformatics.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox