public inbox for [email protected]  

help / color / mirror / Atom feed

From: Ashutosh Sharma <[email protected]>
To: [email protected]
Cc: Michael Meskes <[email protected]>
Subject: #include <stdlib.h> present twice in define.pgc
Date: Mon, 7 Sep 2020 19:17:58 +0530
Message-ID: <CAE9k0PkORqHHGKY54-sFyDpP90yAf+05Auc4fs9EAn4J+uBeUQ@mail.gmail.com> (raw)

Hi All,

I could see that the #include <stdlib.h> statement is present twice in the
define.pgc test file. See below:

[ashu@localhost postgresql]$ head
src/interfaces/ecpg/test/preproc/define.pgc
#include <stdlib.h>
#include <string.h>
#include <stdlib.h>
#include <stdio.h>

exec sql include ../regression;

...
...

Should we consider removing one of them?

I know that there won't be multiple inclusion of the same header file
because of #ifndef and #define pre-processor directives which defines
_STDLIB_H macro that allows the file to included just once, but I still
feel that it is better to avoid having such things. It doesn't do any harm
but is certainly not required. Thoughts?

-- 
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: #include <stdlib.h> present twice in define.pgc
  In-Reply-To: <CAE9k0PkORqHHGKY54-sFyDpP90yAf+05Auc4fs9EAn4J+uBeUQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox