public inbox for [email protected]  

help / color / mirror / Atom feed

#include <stdlib.h> present twice in define.pgc
3+ messages / 2 participants
[nested] [flat]

* #include <stdlib.h> present twice in define.pgc
@ 2020-09-07 13:47  Ashutosh Sharma <[email protected]>
  0 siblings, 1 reply; 3+ messages in thread

From: Ashutosh Sharma @ 2020-09-07 13:47 UTC (permalink / raw)
  To: pgsql-interfaces; +Cc: Michael Meskes <[email protected]>

Hi All,

I could see that the #include <stdlib.h> statement is present twice in the
define.pgc test file. See below:

[ashu@localhost postgresql]$ head
src/interfaces/ecpg/test/preproc/define.pgc
#include <stdlib.h>
#include <string.h>
#include <stdlib.h>
#include <stdio.h>

exec sql include ../regression;

...
...

Should we consider removing one of them?

I know that there won't be multiple inclusion of the same header file
because of #ifndef and #define pre-processor directives which defines
_STDLIB_H macro that allows the file to included just once, but I still
feel that it is better to avoid having such things. It doesn't do any harm
but is certainly not required. Thoughts?

-- 
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com


^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: #include <stdlib.h> present twice in define.pgc
@ 2021-01-25 08:16  Peter Eisentraut <[email protected]>
  parent: Ashutosh Sharma <[email protected]>
  0 siblings, 1 reply; 3+ messages in thread

From: Peter Eisentraut @ 2021-01-25 08:16 UTC (permalink / raw)
  To: Ashutosh Sharma <[email protected]>; pgsql-interfaces; +Cc: Michael Meskes <[email protected]>

On 2020-09-07 15:47, Ashutosh Sharma wrote:
> I could see that the #include <stdlib.h> statement is present twice in 
> the define.pgc test file. See below:
> 
> [ashu@localhost postgresql]$ head 
> src/interfaces/ecpg/test/preproc/define.pgc
> #include <stdlib.h>
> #include <string.h>
> #include <stdlib.h>
> #include <stdio.h>

fixed





^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: #include <stdlib.h> present twice in define.pgc
@ 2021-01-25 11:50  Ashutosh Sharma <[email protected]>
  parent: Peter Eisentraut <[email protected]>
  0 siblings, 0 replies; 3+ messages in thread

From: Ashutosh Sharma @ 2021-01-25 11:50 UTC (permalink / raw)
  To: Peter Eisentraut <[email protected]>; +Cc: pgsql-interfaces; Michael Meskes <[email protected]>

thanks.!

On Monday, January 25, 2021, Peter Eisentraut <
[email protected]> wrote:

> On 2020-09-07 15:47, Ashutosh Sharma wrote:
>
>> I could see that the #include <stdlib.h> statement is present twice in
>> the define.pgc test file. See below:
>>
>> [ashu@localhost postgresql]$ head src/interfaces/ecpg/test/prepr
>> oc/define.pgc
>> #include <stdlib.h>
>> #include <string.h>
>> #include <stdlib.h>
>> #include <stdio.h>
>>
>
> fixed
>


^ permalink  raw  reply  [nested|flat] 3+ messages in thread

end of thread, other threads:[~2021-01-25 11:50 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-09-07 13:47 #include <stdlib.h> present twice in define.pgc Ashutosh Sharma <[email protected]>
2021-01-25 08:16 ` Peter Eisentraut <[email protected]>
2021-01-25 11:50   ` Ashutosh Sharma <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox