From: Vlad <marchenko@gmail.com>
To: Greg Sabino Mullane <greg@turnstep.com>
Cc: dbdpg-general@gborg.postgresql.org
Cc: pgsql-interfaces@postgresql.org
Subject: Re: [Dbdpg-general] benchmarking old Pg and DBD::Pg
Date: Fri, 8 Apr 2005 19:38:11 -0400
Message-ID: <cd70c681050408163838661d9a@mail.gmail.com> (raw)
In-Reply-To: <7faf5fa48d5bef0dbd507740522747bf@biglumber.com>
References: <cd70c68105040813566f6c9c5f@mail.gmail.com>
<7faf5fa48d5bef0dbd507740522747bf@biglumber.com>
Greg,
just re-run my tests with freshly compiled PostgreSQL 8.0.2 (congrats
on release, btw)
DBD:Pg 1.32 - fast
DBD:Pg 1.40 - slooow and buggy, won't work w/o patching
DBD:Pg 1.41 - fast
DBD:Pg 1.41 patched - fast
the patch I've applied in last test:
diff -ru DBD-Pg-1.41/dbdimp.c DBD-Pg-1.41-patched/dbdimp.c
--- DBD-Pg-1.41/dbdimp.c Fri Apr 8 16:06:12 2005
+++ DBD-Pg-1.41-patched/dbdimp.c Fri Apr 8 15:46:50 2005
@@ -1415,7 +1415,7 @@
}
else if (NULL == currph->bind_type) { /* "sticky" data type */
/* This is the default type, but we will honor
defaultval if we can */
- currph->bind_type = pg_type_data(VARCHAROID);
+ currph->bind_type = pg_type_data(UNKNOWNOID);
if (!currph->bind_type)
croak("Default type is bad!!!!???");
}
diff -ru DBD-Pg-1.41/types.c DBD-Pg-1.41-patched/types.c
--- DBD-Pg-1.41/types.c Fri Apr 8 16:06:23 2005
+++ DBD-Pg-1.41-patched/types.c Fri Apr 8 17:23:48 2005
@@ -55,7 +55,7 @@
{ABSTIMEOID, "abstime", DBDPG_TRUE, null_quote, null_dequote, {0}},
{RELTIMEOID, "reltime", DBDPG_TRUE, null_quote, null_dequote, {0}},
{TINTERVALOID, "tinterval", DBDPG_TRUE, null_quote, null_dequote, {0}},
- {UNKNOWNOID, "unknown", DBDPG_FALSE, null_quote, null_dequote, {0}},
+ {UNKNOWNOID, "unknown", DBDPG_FALSE, quote_varchar,
dequote_varchar, {0}},
{CIRCLEOID, "circle", DBDPG_FALSE, null_quote, null_dequote, {0}},
{CASHOID, "money", DBDPG_TRUE, null_quote, null_dequote, {0}},
{MACADDROID, "MAC address", DBDPG_TRUE,
quote_varchar,dequote_varchar, {0}},
On Apr 8, 2005 6:17 PM, Greg Sabino Mullane <greg@turnstep.com> wrote:
> Let's slow down and back up a bit. First, what version of
> PostgreSQL are you using to compile DBD::Pg, and what version
> are you connecting to? Many of the things being discussed
> have already been solved if you are running a modern version
> of PG (e.g. 7.4 or greater).
--
Vlad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-interfaces@postgresql.org
Cc: marchenko@gmail.com, greg@turnstep.com, dbdpg-general@gborg.postgresql.org
Subject: Re: [Dbdpg-general] benchmarking old Pg and DBD::Pg
In-Reply-To: <cd70c681050408163838661d9a@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox