pg.ddx.io  pgsql-patches@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Hiroshi Saito <z-saito@guitar.ocn.ne.jp>
To: Magnus Hagander <magnus@hagander.net>
Cc: pgsql-patches@postgresql.org
Subject: Re: Solve a problem of LC_TIME of windows.
Date: Wed, 24 Sep 2008 23:55:10 +0900
Message-ID: <00a101c91e55$8ad86260$0b01a8c0@IBMC9A0F63B40D> (raw)
References: <03c301c91737$be5a2a30$0e01a8c0@IBMC9A0F63B40D>
	<48DA044D.10005@hagander.net>

Hi.

----- Original Message ----- 
From: "Magnus Hagander" <magnus@hagander.net>

> In principle, I think this patch looks good.
> 
> Do you (or somebody else) have an example where this breaks in an
> encoding where I can actually understand the characters, though ;-) That
> would make testing a whole lot easier...
> 
> Also, the patch needs error checking. strftime() can fail, and the
> multibyte conversion functions can certainly fail. That will need to be
> added.

Ok, thanks!

strftime return to 0.
http://msdn.microsoft.com/en-us/library/fe06s4ak(VS.71).aspx
MultiByteToWideChar and WideCharToMultiByte return to GetLastError.
http://msdn.microsoft.com/en-us/library/ms776413(VS.85).aspx

I will proposal the next patch.:-)

BTW, this is SQL for a check. 
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/LC_TIME_PATCH/DATECHECK.sql
Probably, all are included. 
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/LC_TIME_PATCH/LC_TIME_CHECK_LOCALE.sql

Regards,
Hiroshi Saito

view thread (45+ messages)  latest in thread

Message-ID: <00a101c91e55$8ad86260$0b01a8c0@IBMC9A0F63B40D>
Permalink:  ../00a101c91e55$8ad86260$0b01a8c0@IBMC9A0F63B40D/
Also on:    postgresql.org/message-id/00a101c91e55$8ad86260$0b01a8c0@IBMC9A0F63B40D

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-patches@postgresql.org
  Cc: z-saito@guitar.ocn.ne.jp, magnus@hagander.net
  Subject: Re: Solve a problem of LC_TIME of windows.
  In-Reply-To: <00a101c91e55$8ad86260$0b01a8c0@IBMC9A0F63B40D>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox