From: Simon Riggs <simon@2ndquadrant.com>
To: List pgsql-patches <pgsql-patches@postgresql.org>
Subject: Re: [HACKERS] Userset logging
Date: Tue, 08 Jul 2008 08:36:21 +0100
Message-ID: <1215502581.4051.674.camel@ebony.site> (raw)
In-Reply-To: <1215443593.4051.601.camel@ebony.site>
References: <1215443593.4051.601.camel@ebony.site>
On Mon, 2008-07-07 at 16:13 +0100, Simon Riggs wrote:
> I notice log_temp_files is a PGC_USERSET parameter, which is out of step
> with our current thinking on who is allowed to initiate logging.
>
> Is there a rationale for this? Or should we set this to PGC_SUSET like
> all the other logging functions?
Patch enclosed.
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
Attachments:log_temp_files_suset.v1.patch (text/x-patch, 923B) download
Index: src/backend/utils/misc/guc.c
===================================================================
RCS file: /home/sriggs/pg/REPOSITORY/pgsql/src/backend/utils/misc/guc.c,v
retrieving revision 1.461
diff -c -r1.461 guc.c
*** src/backend/utils/misc/guc.c 1 Jul 2008 21:07:33 -0000 1.461
--- src/backend/utils/misc/guc.c 8 Jul 2008 06:03:18 -0000
***************
*** 1861,1867 ****
},
{
! {"log_temp_files", PGC_USERSET, LOGGING_WHAT,
gettext_noop("Log the use of temporary files larger than this number of kilobytes."),
gettext_noop("Zero logs all files. The default is -1 (turning this feature off)."),
GUC_UNIT_KB
--- 1861,1867 ----
},
{
! {"log_temp_files", PGC_SUSET, LOGGING_WHAT,
gettext_noop("Log the use of temporary files larger than this number of kilobytes."),
gettext_noop("Zero logs all files. The default is -1 (turning this feature off)."),
GUC_UNIT_KB
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-patches@postgresql.org
Cc: simon@2ndquadrant.com
Subject: Re: [HACKERS] Userset logging
In-Reply-To: <1215502581.4051.674.camel@ebony.site>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox