pg.ddx.io  pgsql-patches@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Simon Riggs <simon@2ndQuadrant.com>
To: Alvaro Herrera <alvherre@commandprompt.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: List pgsql-patches <pgsql-patches@postgresql.org>
Subject: Re: [HACKERS] Infrastructure changes for recovery
Date: Fri, 12 Sep 2008 19:56:06 +0100
Message-ID: <1221245766.3913.1130.camel@ebony.2ndQuadrant> (raw)
In-Reply-To: <20080912181421.GI8854@alvh.no-ip.org>
References: <1218109459.4549.423.camel@ebony.2ndQuadrant>
	<1220213074.4371.173.camel@ebony.2ndQuadrant>
	<1905.1220895241@sss.pgh.pa.us>
	<1221080797.3913.768.camel@ebony.2ndQuadrant>
	<20080912181421.GI8854@alvh.no-ip.org>


On Fri, 2008-09-12 at 14:14 -0400, Alvaro Herrera wrote:
> Simon Riggs wrote:
> 
> > --- 5716,5725 ----
> >   						CheckpointStats.ckpt_sync_end_t,
> >   						&sync_secs, &sync_usecs);
> >   
> > ! 	elog(LOG, "%s complete: wrote %d buffers (%.1f%%); "
> >   		 "%d transaction log file(s) added, %d removed, %d recycled; "
> >   		 "write=%ld.%03d s, sync=%ld.%03d s, total=%ld.%03d s",
> > + 		 (checkpoint ? "  checkpoint" : "restartpoint"),
> >   		 CheckpointStats.ckpt_bufs_written,
> >   		 (double) CheckpointStats.ckpt_bufs_written * 100 / NBuffers,
> >   		 CheckpointStats.ckpt_segs_added,
> 
> Very minor nit: this really needs a rework.  

All I changed was the word "restartpoint"... its otherwise identical to
existing message. I'd rather not change that.

-- 
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support

view thread (52+ messages)  latest in thread

Message-ID: <1221245766.3913.1130.camel@ebony.2ndQuadrant>
Permalink:  ../1221245766.3913.1130.camel@ebony.2ndQuadrant/
Also on:    postgresql.org/message-id/1221245766.3913.1130.camel@ebony.2ndQuadrant

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-patches@postgresql.org
  Cc: simon@2ndQuadrant.com, alvherre@commandprompt.com, tgl@sss.pgh.pa.us
  Subject: Re: [HACKERS] Infrastructure changes for recovery
  In-Reply-To: <1221245766.3913.1130.camel@ebony.2ndQuadrant>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox