pg.ddx.io  pgsql-patches@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alex Hunsaker <badalex@gmail.com>
Cc: Xiao Meng <mx.cogito@gmail.com>
Cc: Zdenek Kotala <Zdenek.Kotala@sun.com>
Cc: pgsql-patches@postgresql.org, "Jonah H. Harris" <jonah.harris@gmail.com>
Subject: Re: hash index improving v3
Date: Sat, 06 Sep 2008 14:14:26 -0400
Message-ID: <20927.1220724866@sss.pgh.pa.us> (raw)
In-Reply-To: <34d269d40809052249h59750f83v4b19a50d0555580@mail.gmail.com>
References: <ded849dd0808171846g2c6c65adub942bd2510a6c94f@mail.gmail.com>
	<7627.1220569888@sss.pgh.pa.us>
	<34d269d40809041742r6a0703dbgfbdd012f7f19de2e@mail.gmail.com>
	<10995.1220577198@sss.pgh.pa.us>
	<11525.1220579153@sss.pgh.pa.us>
	<34d269d40809041854g355a8f68ga3a037a69e3d9fcb@mail.gmail.com>
	<11962.1220581027@sss.pgh.pa.us>
	<34d269d40809042048m3b532a5ej7a9588f63a788d0c@mail.gmail.com>
	<34d269d40809050912u33f2afc8mb90e316bc465136e@mail.gmail.com>
	<34d269d40809051321w2ed16037od0373a4a29c311f1@mail.gmail.com>
	<34d269d40809052249h59750f83v4b19a50d0555580@mail.gmail.com>

"Alex Hunsaker" <badalex@gmail.com> writes:
> - 			tbm_add_tuples(tbm, &scan->xs_ctup.t_self, 1, false);
> + 			tbm_add_tuples(tbm, &scan->xs_ctup.t_self, 1, true);

Hah, I bet that explains Jonah's complaint that recheck didn't seem to
be happening in his tests.  Nice catch.

			regards, tom lane



view thread (63+ messages)  latest in thread

Message-ID: <20927.1220724866@sss.pgh.pa.us>
Permalink:  ../20927.1220724866@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/20927.1220724866@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-patches@postgresql.org
  Cc: tgl@sss.pgh.pa.us, badalex@gmail.com, mx.cogito@gmail.com, Zdenek.Kotala@sun.com, jonah.harris@gmail.com
  Subject: Re: hash index improving v3
  In-Reply-To: <20927.1220724866@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox