From: Tom Lane <tgl@sss.pgh.pa.us>
To: daveg <daveg@sonic.net>
Cc: Marko Kreen <markokr@gmail.com>
Cc: pgsql-patches@postgresql.org, hari@efrontier.com, Postgres Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCHES] pg_dump lock timeout
Date: Thu, 03 Jul 2008 11:33:16 -0400
Message-ID: <3001.1215099196@sss.pgh.pa.us> (raw)
In-Reply-To: <20080703125501.GS866@sonic.net>
References: <20080511113047.GV5673@sonic.net>
<e51f66da0807030115y2520ecbdie9d17f6312636f3@mail.gmail.com>
<20080703125501.GS866@sonic.net>
daveg <daveg@sonic.net> writes:
> On Thu, Jul 03, 2008 at 11:15:10AM +0300, Marko Kreen wrote:
>> - The statement_timeout is set back with "statement_timeout = default"
>> Maybe it would be better to do "= 0" here? Although such decision
>> would go outside the scope of the patch, I see no sense having
>> any other statement_timeout for actual dumping.
> I'd prefer to leave whatever policy is otherwise in place alone.
The policy in place in CVS HEAD is that pg_dump explicitly sets
statement_timeout to 0. Setting it to default would break that,
and will certainly not be accepted.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-patches@postgresql.org
Cc: tgl@sss.pgh.pa.us, daveg@sonic.net, markokr@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: [PATCHES] pg_dump lock timeout
In-Reply-To: <3001.1215099196@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox