From: Jaime Casanova <jcasanov@systemguards.com.ec>
To: Ryan Bradetich <rbradetich@gmail.com>
Cc: pgsql-patches <pgsql-patches@postgresql.org>
Subject: Re: [PgFoundry] Unsigned Data Types [1 of 2]
Date: Sat, 6 Sep 2008 15:41:29 -0500
Message-ID: <3073cc9b0809061341q5c747488i85491e4c8e2420ba@mail.gmail.com> (raw)
In-Reply-To: <e739902b0808311335l1ad5d425r2704429c386f2f88@mail.gmail.com>
References: <e739902b0808311335l1ad5d425r2704429c386f2f88@mail.gmail.com>
On Sun, Aug 31, 2008 at 3:35 PM, Ryan Bradetich <rbradetich@gmail.com> wrote:
> Hello all,
>
a few comments.
- i think you have to add some more comments in uint.c file and maybe
a header indicating this is part of the postgresql project or that is
intended to use with postgres or something of the like
- what is uint1? i know int, int2, int4, int8 so i think we should
have uint, uint2, uint4 (maybe uint8?)
> uint-base.tar.bz2 -- The core of the unsigned integer type.
seems there is something wrong in the unlikely macro (i'm using GCC
4.2.3 in Ubuntu 4.2.3-2ubuntu7 with amd64)
postgres=# select -256::uint1;
ERROR: uint1 out of range
STATEMENT: select -256::uint1;
ERROR: uint1 out of range
postgres=# select -255::uint1;
?column?
----------
-255
(1 row)
postgres=# select -2::uint1;
?column?
----------
-2
(1 row)
postgres=# select -5::uint1 + 30::uint1;
?column?
----------
25
(1 row)
> uint-tests.tar.bz2 -- The regression tests.
>
here failed two regression tests but that is because the path
> * Converted build system to use PGXS (more portable).
the Makefile doesn't work here... i have installed postgres 8.3.3 from
ubuntu package and the test env i compile manually (the uint module
tried to install in the ubuntu location while it should in the env
location)
attached a Makefile that fix that
i still have to make some more test...
--
regards,
Jaime Casanova
Soporte y capacitación de PostgreSQL
AsesorÃa y desarrollo de sistemas
Guayaquil - Ecuador
Cel. (593) 87171157
Attachments:
Makefile (application/octet-stream, 656B) download
regression.diffs (application/octet-stream, 3.8K) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-patches@postgresql.org
Cc: jcasanov@systemguards.com.ec, rbradetich@gmail.com
Subject: Re: [PgFoundry] Unsigned Data Types [1 of 2]
In-Reply-To: <3073cc9b0809061341q5c747488i85491e4c8e2420ba@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox