pg.ddx.io  pgsql-patches@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Brendan Jurd <direvus@gmail.com>
To: Alex Hunsaker <badalex@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [PATCHES] to_date() validation
Date: Tue, 9 Sep 2008 04:07:05 +1000
Message-ID: <37ed240d0809081107o63e91b14h34ae40c7bd1288d2@mail.gmail.com> (raw)
In-Reply-To: <37ed240d0809080124y3403224fpe3c34ca90df798a3@mail.gmail.com>
References: <37ed240d0808291839t21e19956mdfbdc80aeb1b3c19@mail.gmail.com>
	<34d269d40809061258t46f90218r3152814dd18880ab@mail.gmail.com>
	<37ed240d0809080124y3403224fpe3c34ca90df798a3@mail.gmail.com>

On Mon, Sep 8, 2008 at 6:24 PM, Brendan Jurd <direvus@gmail.com> wrote:
> On Sun, Sep 7, 2008 at 5:58 AM, Alex Hunsaker <badalex@gmail.com> wrote:
>> Code review: one minor nit
>> *** a/src/backend/utils/adt/formatting.c
>> --- b/src/backend/utils/adt/formatting.c
>> ***************
>> *** 781,787 **** static const KeyWord DCH_keywords[] = {
>>        {"y", 1, DCH_Y, TRUE, FROM_CHAR_DATE_GREGORIAN},
>>
>>        /* last */
>> !       {NULL, 0, 0, 0}
>>  };
>>
>>  /* ----------
>> --- 781,787 ----
>>        {"y", 1, DCH_Y, TRUE, FROM_CHAR_DATE_GREGORIAN},
>>
>>        /* last */
>> !       {NULL, 0, 0, 0, 0}
>>  };
>
> Ah, thank you for picking that up.  I will correct this and send in a
> new patch version in the next 24 hours.
>

New version attached (and link added to wiki).

Cheers,
BJ

Attachments:

  to-date-validation-2.diff.gz (application/x-gzip, 9.4K) download

view thread (11+ messages)  latest in thread

Message-ID: <37ed240d0809081107o63e91b14h34ae40c7bd1288d2@mail.gmail.com>
Permalink:  ../37ed240d0809081107o63e91b14h34ae40c7bd1288d2@mail.gmail.com/
Also on:    postgresql.org/message-id/37ed240d0809081107o63e91b14h34ae40c7bd1288d2@mail.gmail.com

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-patches@postgresql.org
  Cc: direvus@gmail.com, badalex@gmail.com, pgsql-hackers@postgresql.org
  Subject: Re: [PATCHES] to_date() validation
  In-Reply-To: <37ed240d0809081107o63e91b14h34ae40c7bd1288d2@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox