pg.ddx.io  pgsql-patches@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Brendan Jurd <direvus@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Martijn van Oosterhout <kleptog@svana.org>
Cc: Alex Hunsaker <badalex@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [PATCHES] to_date() validation
Date: Fri, 12 Sep 2008 04:12:39 +1000
Message-ID: <37ed240d0809111112i67dffe41q87d72137604bbef0@mail.gmail.com> (raw)
In-Reply-To: <2723.1221154495@sss.pgh.pa.us>
References: <37ed240d0808291839t21e19956mdfbdc80aeb1b3c19@mail.gmail.com>
	<34d269d40809061258t46f90218r3152814dd18880ab@mail.gmail.com>
	<37ed240d0809080124y3403224fpe3c34ca90df798a3@mail.gmail.com>
	<20080909092919.GB29604@svana.org>
	<37ed240d0809090404w2490d375l60b0fc972f899cec@mail.gmail.com>
	<37ed240d0809090546v3024a465j33216e8157bc54ca@mail.gmail.com>
	<2723.1221154495@sss.pgh.pa.us>

On Fri, Sep 12, 2008 at 3:34 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Applied with minimal modifications.  I changed a couple of error
> messages that didn't seem to meet the style guidelines,

Great, thanks Tom.  And thanks again to Alex and Martijn for helping
me refine the patch.

> and I moved all
> of the to_timestamp tests into horology.sql, rather than having
> essentially duplicate tests in timestamp.sql and timestamptz.sql.
>

Nice.  That will make maintaining/extending the tests easier in future.

Cheers,
BJ



view thread (11+ messages)

Message-ID: <37ed240d0809111112i67dffe41q87d72137604bbef0@mail.gmail.com>
Permalink:  ../37ed240d0809111112i67dffe41q87d72137604bbef0@mail.gmail.com/
Also on:    postgresql.org/message-id/37ed240d0809111112i67dffe41q87d72137604bbef0@mail.gmail.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-patches@postgresql.org
  Cc: direvus@gmail.com, tgl@sss.pgh.pa.us, kleptog@svana.org, badalex@gmail.com, pgsql-hackers@postgresql.org
  Subject: Re: [PATCHES] to_date() validation
  In-Reply-To: <37ed240d0809111112i67dffe41q87d72137604bbef0@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox