From: Kris Jurka <books@ejurka.com>
To: Bruce Momjian <pgman@candle.pha.pa.us>
Subject: Re: [BUGS] BUG #2401: spinlocks not available on amd64
Date: Thu, 27 Apr 2006 21:25:48 -0700
Message-ID: <4451994C.8020001@ejurka.com> (raw)
In-Reply-To: <200604272231.k3RMVYM28488@candle.pha.pa.us>
References: <154BA792-BB51-4F85-86E3-0BBAEB732C33@omniti.com>
<200604272231.k3RMVYM28488@candle.pha.pa.us>
Bruce Momjian wrote:
> Great, changes attached and applied. I removed the solaris_i386 and
> solaris_x86_64.s files and made just one solaris_x86.s. I updated the
> build system to use the new file, updated the macros, and added some
> documentation on the approach. Thanks.
>
> Would you test current CVS to make sure it still works properly? Thanks.
>
The patch adds an extra else in src/template/solaris that means the
assembly file is not properly picked up.
Also the claim that Sun's cc understands C preprocessor doesn't hold
true for me:
/usr/local/SUNWspro/bin/cc -Xa -v -DSUNOS4_CC -g -c tas.s
Assembler: tas.s
"tas.s", line 9 : Illegal mnemonic
"tas.s", line 9 : Syntax error
"tas.s", line 9 : Illegal mnemonic
"tas.s", line 9 : Illegal mnemonic
This is with cc -V
cc: Sun WorkShop 6 update 2 C 5.3 Patch 111680-09 2003/05/18
Attachments:solaris-pick-tas.patch (text/plain, 963B) download
Index: src/template/solaris
===================================================================
RCS file: /projects/cvsroot/pgsql/src/template/solaris,v
retrieving revision 1.26
diff -c -r1.26 solaris
*** src/template/solaris 27 Apr 2006 22:28:42 -0000 1.26
--- src/template/solaris 28 Apr 2006 04:20:02 -0000
***************
*** 4,10 ****
if test "$enable_debug" != yes; then
CFLAGS="$CFLAGS -O" # any optimization breaks debug
fi
! else
# Pick the right test-and-set (TAS) code for the Sun compiler.
# We would like to use in-line assembler, but the compiler
# requires *.il files to be on every compile line, making
--- 4,10 ----
if test "$enable_debug" != yes; then
CFLAGS="$CFLAGS -O" # any optimization breaks debug
fi
!
# Pick the right test-and-set (TAS) code for the Sun compiler.
# We would like to use in-line assembler, but the compiler
# requires *.il files to be on every compile line, making
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-patches@postgresql.org
Cc: books@ejurka.com, pgman@candle.pha.pa.us
Subject: Re: [BUGS] BUG #2401: spinlocks not available on amd64
In-Reply-To: <4451994C.8020001@ejurka.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox