From: Jan Wieck <JanWieck@Yahoo.com>
To: Gregory Stark <stark@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-patches@postgreSQL.org
Subject: Re: Proposed patch to change TOAST compression strategy
Date: Wed, 20 Feb 2008 16:14:58 -0500
Message-ID: <47BC9852.9010100@Yahoo.com> (raw)
In-Reply-To: <87ir0mo8ot.fsf@oxford.xeocode.com>
References: <26048.1203271939@sss.pgh.pa.us>
<87ir0mo8ot.fsf@oxford.xeocode.com>
On 2/18/2008 5:33 AM, Gregory Stark wrote:
> "Tom Lane" <tgl@sss.pgh.pa.us> writes:
>
>> * Adds an early-failure path to the compressor as suggested by Jan:
>> if it's been unable to find even one compressible substring in the
>> first 1KB (parameterizable), assume we're looking at incompressible
>> input and give up. (There are various ways this could be done, but
>> this way seems to add the least overhead to the compressor's inner
>> loop.)
>
> I'm not sure how to test the rest of it, but this bit seems testable. I fear
> this may be too conservative. Even nigh incompressible data will find a few
> backreferences.
One could argue that storing JPEG in a bytea column and not configuring
the column to skip compression is a pilot error. But I guess this
happens much more often than accidentally finding some data that has
zero backref within the first KB and changes pattern thereafter. Do you
have any example for data that is like that?
Jan
--
Anyone who trades liberty for security deserves neither
liberty nor security. -- Benjamin Franklin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-patches@postgresql.org
Cc: JanWieck@Yahoo.com, stark@enterprisedb.com, tgl@sss.pgh.pa.us
Subject: Re: Proposed patch to change TOAST compression strategy
In-Reply-To: <47BC9852.9010100@Yahoo.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox