From: Andrew Dunstan <andrew@dunslane.net>
To: Simon Riggs <simon@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: odd output in restore mode
Date: Mon, 12 May 2008 21:15:55 -0400
Message-ID: <4828EBCB.6010004@dunslane.net> (raw)
In-Reply-To: <1210635473.29684.268.camel@ebony.site>
References: <4828AF1D.7060405@dunslane.net>
<1210630440.29684.249.camel@ebony.site>
<4828CB9D.7070102@dunslane.net>
<1210635473.29684.268.camel@ebony.site>
Simon Riggs wrote:
> On Mon, 2008-05-12 at 18:58 -0400, Andrew Dunstan wrote:
>
>
>> No, it had to do with pg_standby waiting for a WAL file that had already
>> gone, somehow. I will try to reproduce it when I get a spare moment.
>>
>
> Sounds like the bug I just fixed.
>
Yes, so I see. I didn't have that fix, so I'll test again with the patch.
>
>
>>> There is an outstanding Windows issue with pg_standby that your help
>>> would be appreciated with, shown on latest commitfest page. It's a
>>> Windows issue and I don't maintain a Windows dev environment.
>>>
>
>
>> The patch has been rejected for now, according to the Commitfest page.
>> Not sure what you want my help on.
>>
>
> Well, the patch was rejected long ago, not sure why its in this
> commitfest. But its an open issue on the Windows port.
>
>
Surely the right fix is to use the recently implemented
pgwin32_safestat() (if we aren't already - I suspect we probably are)
and remove the kluge in pg_standby.c.
cheers
andrew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-patches@postgresql.org
Cc: andrew@dunslane.net, simon@2ndquadrant.com, pgsql-hackers@postgresql.org
Subject: Re: odd output in restore mode
In-Reply-To: <4828EBCB.6010004@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox