From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Simon Riggs <simon@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: odd output in restore mode
Date: Mon, 12 May 2008 23:03:25 -0400
Message-ID: <482904FD.4030006@dunslane.net> (raw)
In-Reply-To: <6489.1210642738@sss.pgh.pa.us>
References: <4828AF1D.7060405@dunslane.net>
<1210630440.29684.249.camel@ebony.site>
<4828CB9D.7070102@dunslane.net>
<1210635473.29684.268.camel@ebony.site>
<4828EBCB.6010004@dunslane.net>
<6489.1210642738@sss.pgh.pa.us>
Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>
>> Simon Riggs wrote:
>>
>>> Well, the patch was rejected long ago, not sure why its in this
>>> commitfest. But its an open issue on the Windows port.
>>>
>
>
>> Surely the right fix is to use the recently implemented
>> pgwin32_safestat() (if we aren't already - I suspect we probably are)
>> and remove the kluge in pg_standby.c.
>>
>
> I think the open issue is how to know whether pgwin32_safestat fixes the
> problem that the kluge tried to work around.
>
>
>
Well, I think we need to consider quite a number of scenarios. The
archive directory could be local, on a remote Windows machine, or on a
remote Samba server. The archive file could be copied by Windows copy,
or Unix cp, or scp, or rsync, among others.
I'd like to know the setup that was found to produce the error, to start
with.
cheers
andrew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-patches@postgresql.org
Cc: andrew@dunslane.net, tgl@sss.pgh.pa.us, simon@2ndquadrant.com, pgsql-hackers@postgresql.org
Subject: Re: odd output in restore mode
In-Reply-To: <482904FD.4030006@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox